diff options
| author | Markus Metzger <markus.t.metzger@intel.com> | 2018-01-19 14:32:09 +0100 |
|---|---|---|
| committer | Markus Metzger <markus.t.metzger@intel.com> | 2018-02-09 14:03:20 +0100 |
| commit | de6242d3075700ec4b73bdee583dc216f3a0b046 (patch) | |
| tree | 1ec1bfd7c1cc4fc218cc6c3efcb66db3b6164c73 /gdb/target.h | |
| parent | 9ee23a853c18da3c83530c7957464bc6b6e9fb16 (diff) | |
| download | gdb-de6242d3075700ec4b73bdee583dc216f3a0b046.zip gdb-de6242d3075700ec4b73bdee583dc216f3a0b046.tar.gz gdb-de6242d3075700ec4b73bdee583dc216f3a0b046.tar.bz2 | |
btrace, gdbserver: remove the to_supports_btrace target method
Remove the to_supports_btrace target method and instead rely on detecting errors
when trying to enable recording. This will also provide a suitable error
message explaining why recording is not possible.
For remote debugging, gdbserver will now always advertise branch tracing related
packets. When talking to an older GDB, this will cause GDB to try to enable
branch tracing and gdbserver to report a suitable error message every time.
An older gdbserver will not advertise branch tracing related packets if the
one-time check failed, so a newer GDB with this patch will fail to enable branch
tracing at remote_enable_btrace() rather than at btrace_enable(). The error
message is the same in both cases so there should be no user-visible change.
gdb/
* btrace.c (btrace_enable): Remove target_supports_btrace call.
* nat/linux-btrace.c (perf_event_pt_event_type): Move.
(kernel_supports_bts, kernel_supports_pt, linux_supports_bts)
(linux_supports_pt, linux_supports_btrace): Remove.
(linux_enable_bts): Call cpu_supports_bts.
* nat/linux-btrace.h (linux_supports_btrace): Remove.
* remote.c (remote_supports_btrace): Remove.
(init_remote_ops): Remove remote_supports_btrace.
* target-delegates.c: Regenerated.
* target.c (target_supports_btrace): Remove.
* target.h (target_ops) <to_supports_btrace>: Remove
(target_supports_btrace): Remove.
* x86-linux-nat.c (x86_linux_create_target): Remove
linux_supports_btrace.
gdbserver/
* linux-low.c (linux_target_ops): Remove linux_supports_btrace.
* nto-low.c (nto_target_ops): Remove NULL for supports_btrace.
* spu-low.c (spu_target_ops): Likewise.
* win32-low.c (win32_target_ops): Likewise.
* server.c (supported_btrace_packets): Report packets unconditionally.
* target.h (target_ops) <supports_btrace>: Remove.
(target_supports_btrace): Remove.
Diffstat (limited to 'gdb/target.h')
| -rw-r--r-- | gdb/target.h | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/gdb/target.h b/gdb/target.h index 096252a..83cf485 100644 --- a/gdb/target.h +++ b/gdb/target.h @@ -1110,10 +1110,6 @@ struct target_ops int (*to_can_use_agent) (struct target_ops *) TARGET_DEFAULT_RETURN (0); - /* Check whether the target supports branch tracing. */ - int (*to_supports_btrace) (struct target_ops *, enum btrace_format) - TARGET_DEFAULT_RETURN (0); - /* Enable branch tracing for PTID using CONF configuration. Return a branch trace target information struct for reading and for disabling branch trace. */ @@ -2428,9 +2424,6 @@ extern void update_target_permissions (void); /* Imported from machine dependent code. */ -/* See to_supports_btrace in struct target_ops. */ -extern int target_supports_btrace (enum btrace_format); - /* See to_enable_btrace in struct target_ops. */ extern struct btrace_target_info * target_enable_btrace (ptid_t ptid, const struct btrace_config *); |