[gdb] Don't create registry keys in destructor

Creating a registry key using emplace calls new:
...
      DATA *result = new DATA (std::forward<Args> (args)...);
...
which can throw a bad alloc, which will terminate gdb if called from a
destructor.

Fix this in a few places.

Tested on aarch64-linux.

Approved-By: Tom Tromey <tom@tromey.com>

1 files changed, 2 insertions, 0 deletions

diff --git a/gdb/source.h b/gdb/source.h
index 33ccda7..f56e7b5 100644
--- a/gdb/source.h
+++ b/gdb/source.h
@@ -25,6 +25,7 @@
 struct program_space;
 struct symtab;
 struct symtab_and_line;
+struct objfile;
 
 /* See openp function definition for their description.  */
 
@@ -132,6 +133,7 @@ extern symtab_and_line set_current_source_symtab_and_line
 
 /* Reset any information stored about a default file and line to print.  */
 extern void clear_current_source_symtab_and_line (program_space *pspace);
+extern void clear_current_source_symtab_and_line (objfile *objfile);
 
 /* Add a source path substitution rule.  */
 extern void add_substitute_path_rule (const char *, const char *);