diff options
| author | Tom Tromey <tromey@adacore.com> | 2020-06-15 06:28:09 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2020-06-15 06:28:10 -0600 |
| commit | 669203174311c5be76744a879563c697cd479853 (patch) | |
| tree | 77b21ddbec4501e2cf04dafd9987a347d66e8cc2 /gdb/solib-darwin.c | |
| parent | a5d871ddaf2aa8462922ed25b0c0dc7f02128cb9 (diff) | |
| download | gdb-669203174311c5be76744a879563c697cd479853.zip gdb-669203174311c5be76744a879563c697cd479853.tar.gz gdb-669203174311c5be76744a879563c697cd479853.tar.bz2 | |
Change target_read_string API
This simplifies the target_read_string API a bit.
Note that some code was using safe_strerror on the error codes
returned by target_read_string. It seems to me that this is incorrect
(if it was ever correct, it must have been quite a long time ago).
gdb/ChangeLog
2020-06-15 Tom Tromey <tromey@adacore.com>
* windows-nat.c (windows_nat::handle_output_debug_string):
Update.
(windows_nat::handle_ms_vc_exception): Update.
* target.h (target_read_string): Change API.
* target.c (target_read_string): Change API.
* solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
Update.
* solib-frv.c (frv_current_sos): Update.
* solib-dsbt.c (dsbt_current_sos): Update.
* solib-darwin.c (darwin_current_sos): Update.
* linux-thread-db.c (inferior_has_bug): Update.
* expprint.c (print_subexp_standard): Update.
* ada-lang.c (ada_main_name, ada_tag_name_from_tsd)
(ada_exception_message_1): Update.
Diffstat (limited to 'gdb/solib-darwin.c')
| -rw-r--r-- | gdb/solib-darwin.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/gdb/solib-darwin.c b/gdb/solib-darwin.c index ee0483d..3806c7e 100644 --- a/gdb/solib-darwin.c +++ b/gdb/solib-darwin.c @@ -251,8 +251,6 @@ darwin_current_sos (void) CORE_ADDR path_addr; struct mach_o_header_external hdr; unsigned long hdr_val; - gdb::unique_xmalloc_ptr<char> file_path; - int errcode; /* Read image info from inferior. */ if (target_read_memory (iinfo, buf, image_info_size)) @@ -275,9 +273,9 @@ darwin_current_sos (void) if (hdr_val == BFD_MACH_O_MH_EXECUTE) continue; - target_read_string (path_addr, &file_path, - SO_NAME_MAX_PATH_SIZE - 1, &errcode); - if (errcode) + gdb::unique_xmalloc_ptr<char> file_path + = target_read_string (path_addr, SO_NAME_MAX_PATH_SIZE - 1); + if (file_path == nullptr) break; /* Create and fill the new so_list element. */ |