aboutsummaryrefslogtreecommitdiff
path: root/gdb/remote-utils.c
diff options
context:
space:
mode:
authorJim Kingdon <jkingdon@engr.sgi.com>1994-10-15 18:28:35 +0000
committerJim Kingdon <jkingdon@engr.sgi.com>1994-10-15 18:28:35 +0000
commit9de0904cce9f2bd32549eade2917c1d2b7256e14 (patch)
tree4751bae933df4c23dcb7e4ce628244dcb45ef532 /gdb/remote-utils.c
parente080a68fce6b8e73c9869a6016d726f820dee7fc (diff)
downloadgdb-9de0904cce9f2bd32549eade2917c1d2b7256e14.zip
gdb-9de0904cce9f2bd32549eade2917c1d2b7256e14.tar.gz
gdb-9de0904cce9f2bd32549eade2917c1d2b7256e14.tar.bz2
* symfile.c (reread_symbols): Include bfd_errmsg string in error
message if bfd_close fails. * exec.c (exec_close), solib.c (clear_solib), corelow.c (core_close), objfiles.c (free_objfile), irix5-nat.c (clear_solib), osfsolib.c (clear_solib), remote-utils.c (gr_load_image): Check for errors from bfd_close. * solib.c (look_for_base), remote-utils.c (gr_load_image), remote-udi.c (download), corelow.c (core_open), symfile.c (symfile_bfd_open), symfile.c (generic_load): Add comment regarding error from bfd_close. * remote-udi.c (download), remote-utils.c (gr_load_image): Add comment about bogus handling of errors from bfd_openr. * exec.c (exec_close): Add comment regarding memory leak and dangling reference to vp->name.
Diffstat (limited to 'gdb/remote-utils.c')
-rw-r--r--gdb/remote-utils.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/gdb/remote-utils.c b/gdb/remote-utils.c
index ba7d2971..f1e949a 100644
--- a/gdb/remote-utils.c
+++ b/gdb/remote-utils.c
@@ -648,8 +648,13 @@ gr_load_image (args, fromtty)
abfd = bfd_openr (args, (char *) 0);
if (!abfd)
+ /* FIXME: should be using bfd_errmsg, not assuming it was
+ bfd_error_system_call. */
perror_with_name (args);
+ /* FIXME: should be checking for errors from bfd_close (for one thing,
+ on error it does not free all the storage associated with the
+ bfd). */
old_cleanups = make_cleanup (bfd_close, abfd);
QUIT;
@@ -682,7 +687,9 @@ gr_load_image (args, fromtty)
free (buffer);
write_pc (bfd_get_start_address (abfd));
- bfd_close (abfd);
+ if (!bfd_close (abfd))
+ warning ("cannot close \"%s\": %s",
+ args, bfd_errmsg (bfd_get_error ()));
discard_cleanups (old_cleanups);
}