diff options
| author | Andrew Burgess <aburgess@redhat.com> | 2024-11-10 14:35:22 +0000 |
|---|---|---|
| committer | Andrew Burgess <aburgess@redhat.com> | 2024-11-14 19:34:43 +0000 |
| commit | dcf4c484539a9ab5fdd0c5ddf43617986480b9bc (patch) | |
| tree | cdc3b0d6d7c767d841ce113e840579ebcf382621 /gdb/python/python.c | |
| parent | 768f23b94f3360058cdfa873e75ba563a600e994 (diff) | |
| download | gdb-dcf4c484539a9ab5fdd0c5ddf43617986480b9bc.zip gdb-dcf4c484539a9ab5fdd0c5ddf43617986480b9bc.tar.gz gdb-dcf4c484539a9ab5fdd0c5ddf43617986480b9bc.tar.bz2 | |
gdb/python: remove PyObject_IsTrue call in gdbpy_handle_missing_debuginfo
In this review:
https://inbox.sourceware.org/gdb-patches/87wmirfzih.fsf@tromey.com
Tom pointed out that using PyObject_IsTrue as I was doing, though
technically fine, at least appears to be missing an error check, and
that it would be better to compare to Py_True directly. I made that
change in the patch Tom was commenting on, but I'd actually copied
that code from elsewhere in python/python.c, so this commit updates
the original code inline with Tom's review feedback.
There should be no functional change after this commit.
Approved-By: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'gdb/python/python.c')
| -rw-r--r-- | gdb/python/python.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/gdb/python/python.c b/gdb/python/python.c index b0de48d..397431a 100644 --- a/gdb/python/python.c +++ b/gdb/python/python.c @@ -1810,7 +1810,9 @@ gdbpy_handle_missing_debuginfo (const struct extension_language_defn *extlang, if (PyBool_Check (pyo_execute_ret.get ())) { - bool try_again = PyObject_IsTrue (pyo_execute_ret.get ()); + /* We know the value is a bool, so it must be either Py_True or + Py_False. Anything else would not get past the above check. */ + bool try_again = pyo_execute_ret.get () == Py_True; return ext_lang_missing_file_result (try_again); } |