diff options
| author | Tom Tromey <tromey@adacore.com> | 2024-09-11 10:35:20 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2024-09-23 13:44:59 -0600 |
| commit | 336bb2a1c1d24f5db07394a109f7cd6c5b58b10d (patch) | |
| tree | 5a8d54ecc8d127a2113712203f1c66aa9c5d8c0e /gdb/python/py-symbol.c | |
| parent | b9155b800c6be57a7f4933a4fd8c5c5d51414e77 (diff) | |
| download | gdb-336bb2a1c1d24f5db07394a109f7cd6c5b58b10d.zip gdb-336bb2a1c1d24f5db07394a109f7cd6c5b58b10d.tar.gz gdb-336bb2a1c1d24f5db07394a109f7cd6c5b58b10d.tar.bz2 | |
Automatically add types to Python modules
PR python/32163 points out that various types provided by gdb are not
added to the gdb module, so they aren't available for interactive
inspection. I think this is just an oversight.
This patch fixes the problem by introducing a new helper function that
both readies the type and then adds it to the appropriate module. The
patch also poisons PyType_Ready, the idea being to avoid this bug in
the future.
v2:
* Fixed a bug in original patch in gdb.Architecture registration
* Added regression test for the types mentioned in the bug
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32163
Reviewed-By: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
Diffstat (limited to 'gdb/python/py-symbol.c')
| -rw-r--r-- | gdb/python/py-symbol.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/gdb/python/py-symbol.c b/gdb/python/py-symbol.c index 754420f..1c3a675 100644 --- a/gdb/python/py-symbol.c +++ b/gdb/python/py-symbol.c @@ -640,7 +640,7 @@ gdbpy_lookup_static_symbols (PyObject *self, PyObject *args, PyObject *kw) static int CPYCHECKER_NEGATIVE_RESULT_SETS_EXCEPTION gdbpy_initialize_symbols (void) { - if (PyType_Ready (&symbol_object_type) < 0) + if (gdbpy_type_ready (&symbol_object_type) < 0) return -1; if (PyModule_AddIntConstant (gdb_module, "SYMBOL_LOC_UNDEF", LOC_UNDEF) < 0 @@ -685,8 +685,7 @@ gdbpy_initialize_symbols (void) #include "sym-domains.def" #undef SYM_DOMAIN - return gdb_pymodule_addobject (gdb_module, "Symbol", - (PyObject *) &symbol_object_type); + return 0; } GDBPY_INITIALIZE_FILE (gdbpy_initialize_symbols); |