diff options
| author | Andrew Burgess <aburgess@redhat.com> | 2024-10-08 10:34:02 +0100 |
|---|---|---|
| committer | Andrew Burgess <aburgess@redhat.com> | 2024-10-10 17:36:21 +0100 |
| commit | d2f8a107b79a44d64fedc843b9843704dae035a6 (patch) | |
| tree | 2d4579695dc35e4ed3dcd826b5f1ba71f506fa33 /gdb/osabi.h | |
| parent | 67470b3532fd031959169740fa99550fc8a06b84 (diff) | |
| download | gdb-d2f8a107b79a44d64fedc843b9843704dae035a6.zip gdb-d2f8a107b79a44d64fedc843b9843704dae035a6.tar.gz gdb-d2f8a107b79a44d64fedc843b9843704dae035a6.tar.bz2 | |
gdb/gdbserver: change shared set_tdesc_osabi to take gdb_osabi
There is a single declaration of set_tdesc_osabi that is shared
between gdbserver/ and gdb/, this declaration takes a 'const char *'
argument which is the string representing an osabi.
Then in gdb/ we have an overload of set_tdesc_osabi which takes an
'enum gdb_osabi'.
In this commit I change the shared set_tdesc_osabi to be the version
which takes an 'enum gdb_osabi', and I remove the version which takes
a 'const char *'. All users of set_tdesc_osabi are updated to pass an
'enum gdb_osabi'.
The features/ code, which is generated from the xml files, requires a
new function to be added to osabi.{c,h} which can return a string
representation of an 'enum gdb_osabi'. With that new function in
place the features/ code is regenerated.
This change is being made to support the next commit. In the next
commit gdbserver will be updated to call set_tdesc_osabi in more
cases. The problem is that gdbserver stores the osabi as a string.
The issue here is that a typo in the gdbserver/ code might go
unnoticed and result in gdbserver sending back an invalid osabi
string.
To fix this we want gdbserver to pass an 'enum gdb_osabi' to the
set_tdesc_osabi function. With that requirement in place it seems to
make sense if all calls to set_tdesc_osabi pass an 'enum gdb_osabi'.
There should be no user visible changes after this commit.
Approved-By: Luis Machado <luis.machado@arm.com>
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Diffstat (limited to 'gdb/osabi.h')
| -rw-r--r-- | gdb/osabi.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/gdb/osabi.h b/gdb/osabi.h index 9a1681d..2d828d5 100644 --- a/gdb/osabi.h +++ b/gdb/osabi.h @@ -52,4 +52,8 @@ void gdbarch_init_osabi (struct gdbarch_info, struct gdbarch *); void generic_elf_osabi_sniff_abi_tag_sections (bfd *, asection *, enum gdb_osabi *); +/* Return a string version of OSABI. This is used when generating code + which calls set_tdesc_osabi and an 'enum gdb_osabi' value is needed. */ +const char *gdbarch_osabi_enum_name (enum gdb_osabi osabi); + #endif /* OSABI_H */ |