diff options
| author | Pedro Alves <palves@redhat.com> | 2010-02-22 23:35:17 +0000 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2010-02-22 23:35:17 +0000 |
| commit | 85d721b88f7efe93142bb8aa8de6f5181830d1dc (patch) | |
| tree | 4b1400e76058dff90370a63a36fe88680ba41d39 /gdb/gdbserver | |
| parent | 4c7f0517f37d925f3e1174cef660bef7e102695c (diff) | |
| download | gdb-85d721b88f7efe93142bb8aa8de6f5181830d1dc.zip gdb-85d721b88f7efe93142bb8aa8de6f5181830d1dc.tar.gz gdb-85d721b88f7efe93142bb8aa8de6f5181830d1dc.tar.bz2 | |
2010-02-22 Pedro Alves <pedro@codesourcery.com>
PR9605
gdb/
* breakpoint.c (insert_bp_location): If inserting the read
watchpoint failed, fallback to an access watchpoint.
(bpstat_check_watchpoint): Stop for read watchpoint triggers even
if the value changed, if not watching the same memory for writes.
(watchpoint_locations_match): Add comment.
(update_global_location_list): Copy the location's watchpoint type.
* i386-nat.c (i386_length_and_rw_bits): It's an internal error to
handle read watchpoints here.
(i386_insert_watchpoint): Read watchpoints aren't supported.
* remote.c (remote_insert_watchpoint): Return 1 for unsupported
packets.
* target.h (target_insert_watchpoint): Update description.
2010-02-22 Pedro Alves <pedro@codesourcery.com>
PR9605
gdbserver/
* i386-low.c (i386_length_and_rw_bits): Throw a fatal error if
handing a read watchpoint.
(i386_low_insert_watchpoint): Read watchpoints aren't supported.
2010-02-22 Pedro Alves <pedro@codesourcery.com>
PR9605
gdb/testsuite/
* gdb.base/watch-read.c, gdb.base/watch-read.exp: New files.
Diffstat (limited to 'gdb/gdbserver')
| -rw-r--r-- | gdb/gdbserver/ChangeLog | 8 | ||||
| -rw-r--r-- | gdb/gdbserver/i386-low.c | 5 |
2 files changed, 12 insertions, 1 deletions
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index fb968eb..f7f96cf 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,11 @@ +2010-02-22 Pedro Alves <pedro@codesourcery.com> + + PR9605 + + * i386-low.c (i386_length_and_rw_bits): Throw a fatal error if + handing a read watchpoint. + (i386_low_insert_watchpoint): Read watchpoints aren't supported. + 2010-02-12 Doug Evans <dje@google.com> * linux-low.c (linux_supports_tracefork_flag): Document. diff --git a/gdb/gdbserver/i386-low.c b/gdb/gdbserver/i386-low.c index 3fdf563..494b808 100644 --- a/gdb/gdbserver/i386-low.c +++ b/gdb/gdbserver/i386-low.c @@ -219,7 +219,7 @@ i386_length_and_rw_bits (int len, enum target_hw_bp_type type) rw = DR_RW_WRITE; break; case hw_read: - /* The i386 doesn't support data-read watchpoints. */ + fatal ("The i386 doesn't support data-read watchpoints.\n"); case hw_access: rw = DR_RW_READ; break; @@ -458,6 +458,9 @@ i386_low_insert_watchpoint (struct i386_debug_reg_state *state, int retval; enum target_hw_bp_type type = Z_packet_to_hw_type (type_from_packet); + if (type == hw_read) + return 1; /* unsupported */ + if (((len != 1 && len != 2 && len != 4) && !(TARGET_HAS_DR_LEN_8 && len == 8)) || addr % len != 0) |