diff options
author | Pedro Alves <palves@redhat.com> | 2014-11-12 11:17:39 +0000 |
---|---|---|
committer | Pedro Alves <palves@redhat.com> | 2014-11-12 11:30:49 +0000 |
commit | 78708b7c8ccc2138880217de9bd60eceff683f10 (patch) | |
tree | 14879775cc59226c4afd3361647616dd69fed1f1 /gdb/gdbserver/ChangeLog | |
parent | 6218dc4bdb198bc4982516ba0b8a6714c9123a8f (diff) | |
download | gdb-78708b7c8ccc2138880217de9bd60eceff683f10.zip gdb-78708b7c8ccc2138880217de9bd60eceff683f10.tar.gz gdb-78708b7c8ccc2138880217de9bd60eceff683f10.tar.bz2 |
GDBserver: ctrl-c after leader has exited
The target->request_interrupt callback implements the handling for
ctrl-c. User types ctrl-c in GDB, GDB sends a \003 to the remote
target, and the remote targets stops the program with a SIGINT, just
like if the user typed ctrl-c in GDBserver's terminal.
The trouble is that using kill_lwp(signal_pid, SIGINT) sends the
SIGINT directly to the program's main thread. If that thread has
exited already, then that kill won't do anything.
Instead, send the SIGINT to the process group, just like GDB
does (see inf-ptrace.c:inf_ptrace_stop).
gdb.threads/leader-exit.exp is extended to cover the scenario. It
fails against GDBserver before the patch.
Tested on x86_64 Fedora 20, native and GDBserver.
gdb/gdbserver/
2014-11-12 Pedro Alves <palves@redhat.com>
* linux-low.c (linux_request_interrupt): Always send a SIGINT to
the process group instead of to a specific LWP.
gdb/testsuite/
2014-11-12 Pedro Alves <palves@redhat.com>
* gdb.threads/leader-exit.exp: Test sending ctrl-c works after the
leader has exited.
Diffstat (limited to 'gdb/gdbserver/ChangeLog')
-rw-r--r-- | gdb/gdbserver/ChangeLog | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 0940fa0..dbb8ce5 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,8 @@ +2014-11-12 Pedro Alves <palves@redhat.com> + + * linux-low.c (linux_request_interrupt): Always send a SIGINT to + the process group instead of to a specific LWP. + 2014-10-15 Pedro Alves <palves@redhat.com> PR server/17487 |