diff options
| author | Tom Tromey <tom@tromey.com> | 2020-12-15 17:53:34 -0700 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2020-12-15 17:53:34 -0700 |
| commit | 1ab8280d7dbe01f51929d221621d38450f31895d (patch) | |
| tree | 6ae791784db83a48b4cf9877e4f2a1ee481d3c92 /gdb/f-lang.c | |
| parent | cf608cc40c523537046efde52e9d68303e8bde00 (diff) | |
| download | gdb-1ab8280d7dbe01f51929d221621d38450f31895d.zip gdb-1ab8280d7dbe01f51929d221621d38450f31895d.tar.gz gdb-1ab8280d7dbe01f51929d221621d38450f31895d.tar.bz2 | |
Clean up arguments to evaluate_subexp_do_call
I noticed hat evaluate_subexp_do_call takes an array of arguments and
a count -- but, unlike the usual convention, the count does not
include the first element.
This patch changes this function to match call_function_by_hand --
passing the callee separately, and using an array_view for the
arguments. This makes it simpler to understand.
Regression tested on x86-64 Fedora 28.
gdb/ChangeLog
2020-12-15 Tom Tromey <tom@tromey.com>
* f-lang.c (evaluate_subexp_f): Update.
* expression.h (evaluate_subexp_do_call): Update.
* eval.c (evaluate_subexp_do_call): Add callee parameter. Replace
nargs, argvec with array_view.
(evaluate_funcall): Update.
Diffstat (limited to 'gdb/f-lang.c')
| -rw-r--r-- | gdb/f-lang.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/gdb/f-lang.c b/gdb/f-lang.c index bbece50..28a66fd 100644 --- a/gdb/f-lang.c +++ b/gdb/f-lang.c @@ -947,8 +947,10 @@ evaluate_subexp_f (struct type *expect_type, struct expression *exp, argvec[tem] = 0; /* signal end of arglist */ if (noside == EVAL_SKIP) return eval_skip_value (exp); - return evaluate_subexp_do_call (exp, noside, nargs, argvec, NULL, - expect_type); + return evaluate_subexp_do_call (exp, noside, argvec[0], + gdb::make_array_view (argvec + 1, + nargs), + NULL, expect_type); } default: |