diff options
| author | Tom Tromey <tromey@adacore.com> | 2021-01-08 12:20:12 -0700 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2021-01-08 12:20:43 -0700 |
| commit | 8fc48b79618af335d6cea1d1d149668340298b81 (patch) | |
| tree | fff5e183fda0fd399702add8a0257b6d36440090 /gdb/expression.h | |
| parent | 6abd4cf281deda4b1eb2d569a2729a485105e553 (diff) | |
| download | gdb-8fc48b79618af335d6cea1d1d149668340298b81.zip gdb-8fc48b79618af335d6cea1d1d149668340298b81.tar.gz gdb-8fc48b79618af335d6cea1d1d149668340298b81.tar.bz2 | |
Pass void_context_p to parse_expression
An earlier patch pointed out that nothing in GDB sets void_context_p
when parsing an expression. This patch fixes this omission.
"print" and "call" differ in that the former will print a value that
has void type, while the latter will not. AdaCore has had a patch for
a long time that uses this distinction to help with overload
resolution. In particular, in a "call" context, a procedure will be
chosen, while in a "print" context, a zero-argument function will be
chosen instead.
Regression tested on x86-64 Fedora 32.
gdb/ChangeLog
2021-01-08 Tom Tromey <tromey@adacore.com>
* parse.c (parse_expression): Add void_context_p parameter. Use
parse_exp_in_context.
* printcmd.c (print_command_1): Change voidprint to bool. Pass to
parse_expression.
(print_command, call_command): Update.
* expression.h (parse_expression): Add void_context_p parameter.
gdb/testsuite/ChangeLog
2021-01-08 Tom Tromey <tromey@adacore.com>
* gdb.ada/voidctx/pck.adb: New file.
* gdb.ada/voidctx/pck.ads: New file.
* gdb.ada/voidctx/voidctx.adb: New file.
* gdb.ada/voidctx.exp: New file.
Diffstat (limited to 'gdb/expression.h')
| -rw-r--r-- | gdb/expression.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/gdb/expression.h b/gdb/expression.h index 8c0bcc9..e70169e 100644 --- a/gdb/expression.h +++ b/gdb/expression.h @@ -142,7 +142,8 @@ typedef std::unique_ptr<expression> expression_up; class innermost_block_tracker; extern expression_up parse_expression (const char *, - innermost_block_tracker * = nullptr); + innermost_block_tracker * = nullptr, + bool void_context_p = false); extern expression_up parse_expression_with_language (const char *string, enum language lang); |