diff options
author | Tom de Vries <tdevries@suse.de> | 2022-11-26 14:13:06 +0100 |
---|---|---|
committer | Tom de Vries <tdevries@suse.de> | 2022-11-26 14:13:06 +0100 |
commit | 05ad0d60341f0933501dc90002da3d4594c30438 (patch) | |
tree | 32f5030888a22e34adae54fa13a9a37b3b414326 /gdb/dwarf2 | |
parent | 14ae285f344fe76aff1d0da8366cd54599aea730 (diff) | |
download | gdb-05ad0d60341f0933501dc90002da3d4594c30438.zip gdb-05ad0d60341f0933501dc90002da3d4594c30438.tar.gz gdb-05ad0d60341f0933501dc90002da3d4594c30438.tar.bz2 |
[gdb/symtab] Handle failure to open .gnu_debugaltlink file
If we instrument cc-with-tweaks.sh to remove the .gnu_debugaltlink file after
dwz has created it, with test-case
gdb.threads/access-mem-running-thread-exit.exp and target board cc-with-dwz-m
we run into:
...
(gdb) file access-mem-running-thread-exit^M
Reading symbols from access-mem-running-thread-exit...^M
could not find '.gnu_debugaltlink' file for access-mem-running-thread-exit^M
...
followed a bit later by:
...
(gdb) file access-mem-running-thread-exit^M
Reading symbols from access-mem-running-thread-exit...^M
gdb/dwarf2/read.c:7284: internal-error: create_all_units: \
Assertion `per_objfile->per_bfd->all_units.empty ()' failed.^M
...
The problem is that create_units does not catch the error thrown by
dwarf2_get_dwz_file.
Fix this by catching the error and performing the necessary cleanup, getting
the same result for the first and second file command.
PR symtab/29805
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29805
Diffstat (limited to 'gdb/dwarf2')
-rw-r--r-- | gdb/dwarf2/read.c | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 60e120a..53a6a8b 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -7291,7 +7291,16 @@ create_all_units (dwarf2_per_objfile *per_objfile) &per_objfile->per_bfd->abbrev, 0, types_htab, rcuh_kind::TYPE); - dwz_file *dwz = dwarf2_get_dwz_file (per_objfile->per_bfd); + dwz_file *dwz; + try + { + dwz = dwarf2_get_dwz_file (per_objfile->per_bfd); + } + catch (const gdb_exception_error &) + { + per_objfile->per_bfd->all_units.clear (); + throw; + } if (dwz != NULL) { /* Pre-read the sections we'll need to construct an index. */ |