diff options
| author | Jan Kratochvil <jan.kratochvil@redhat.com> | 2015-01-22 21:02:24 +0100 |
|---|---|---|
| committer | Jan Kratochvil <jan.kratochvil@redhat.com> | 2015-01-22 21:02:24 +0100 |
| commit | f0e8c4c5d1bce422ac86090b76c28931b0d240bf (patch) | |
| tree | a37353a8e0621740bd423b9b8d2d34af6f2b0557 /gdb/corelow.c | |
| parent | 53bef1c10759f1fd7faf675459871b2f4cc12e53 (diff) | |
| download | gdb-f0e8c4c5d1bce422ac86090b76c28931b0d240bf.zip gdb-f0e8c4c5d1bce422ac86090b76c28931b0d240bf.tar.gz gdb-f0e8c4c5d1bce422ac86090b76c28931b0d240bf.tar.bz2 | |
Print current thread after loading a core file
downstream Fedora request:
Please make it easier to find the backtrace of the crashing thread
https://bugzilla.redhat.com/show_bug.cgi?id=1024504
Currently after loading a core file GDB prints:
Core was generated by `./threadcrash1'.
Program terminated with signal SIGSEGV, Segmentation fault.
8 *(volatile int *)0=0;
(gdb) _
there is nowhere seen which of the threads had crashed. In reality GDB always
numbers that thread as #1 and it is the current thread that time. But after
dumping all the info into a file for later analysis it is no longer obvious.
'thread apply all bt' even puts the thread #1 to the _end_ of the output!!!
Should GDB always print after loading a core file what "thread" command would
print?
[Current thread is 1 (Thread 0x7fcbe28fe700 (LWP 15453))]
BTW I think it will print the thread even when loading single/non-threaded
core file when other inferior(s) exist. But that currently crashes
[Bug threads/12074] multi-inferior internal error
https://sourceware.org/bugzilla/show_bug.cgi?id=12074
plus I think that would be a correct behavior anyway.
gdb/ChangeLog
2015-01-22 Jan Kratochvil <jan.kratochvil@redhat.com>
* corelow.c (core_open): Call also thread_command.
* gdbthread.h (thread_command): New prototype moved from ...
* thread.c (thread_command): ... here.
(thread_command): Make it global.
Diffstat (limited to 'gdb/corelow.c')
| -rw-r--r-- | gdb/corelow.c | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/gdb/corelow.c b/gdb/corelow.c index a9eadd5..6a67a98 100644 --- a/gdb/corelow.c +++ b/gdb/corelow.c @@ -456,6 +456,19 @@ core_open (const char *arg, int from_tty) /* Now, set up the frame cache, and print the top of stack. */ reinit_frame_cache (); print_stack_frame (get_selected_frame (NULL), 1, SRC_AND_LOC, 1); + + /* Current thread should be NUM 1 but the user does not know that. + If a program is single threaded gdb in general does not mention + anything about threads. That is why the test is >= 2. */ + if (thread_count () >= 2) + { + TRY_CATCH (except, RETURN_MASK_ERROR) + { + thread_command (NULL, from_tty); + } + if (except.reason < 0) + exception_print (gdb_stderr, except); + } } static void |