diff options
| author | Tom Tromey <tromey@redhat.com> | 2014-01-18 14:42:54 -0700 |
|---|---|---|
| committer | Tom Tromey <tromey@redhat.com> | 2014-02-12 09:59:15 -0700 |
| commit | 9f1b45b0da430a7a7abf9e54acbe6f2ef9d3a763 (patch) | |
| tree | 361786ccaba5933381119910e146b7482857b06f /gdb/common | |
| parent | 9c3d65319a230a106392e4b67c8c89c8f5e2929f (diff) | |
| download | gdb-9f1b45b0da430a7a7abf9e54acbe6f2ef9d3a763.zip gdb-9f1b45b0da430a7a7abf9e54acbe6f2ef9d3a763.tar.gz gdb-9f1b45b0da430a7a7abf9e54acbe6f2ef9d3a763.tar.bz2 | |
don't let bin2hex call strlen
Currently bin2hex may call strlen if the length argument is zero.
This prevents some function unification; and also it seems cleaner to
me not to have a special meaning for a zero length.
2014-02-12 Tom Tromey <tromey@redhat.com>
* common/rsp-low.c (bin2hex): Never take strlen of argument.
* remote.c (extended_remote_run, remote_rcmd)
(remote_download_trace_state_variable, remote_save_trace_data)
(remote_set_trace_notes): Update.
* tracepoint.c (encode_source_string, tfile_write_status)
(tfile_write_uploaded_tsv): Update.
Diffstat (limited to 'gdb/common')
| -rw-r--r-- | gdb/common/rsp-low.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/gdb/common/rsp-low.c b/gdb/common/rsp-low.c index 07e7ddb..7f0445c 100644 --- a/gdb/common/rsp-low.c +++ b/gdb/common/rsp-low.c @@ -163,10 +163,6 @@ bin2hex (const gdb_byte *bin, char *hex, int count) { int i; - /* May use a length, or a nul-terminated string as input. */ - if (count == 0) - count = strlen ((char *) bin); - for (i = 0; i < count; i++) { *hex++ = tohex ((*bin >> 4) & 0xf); |