diff options
| author | Pedro Alves <palves@redhat.com> | 2015-03-09 11:27:05 +0000 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2015-03-09 11:27:05 +0000 |
| commit | 9eb1356e381f3412f53ffe5bc68ce854330600fb (patch) | |
| tree | 1a764e6c10e8942911c65b959e99eae4e9d774e4 /gdb/common | |
| parent | 43fa85d9a8d7aac7a70c72220abd09d39703208a (diff) | |
| download | gdb-9eb1356e381f3412f53ffe5bc68ce854330600fb.zip gdb-9eb1356e381f3412f53ffe5bc68ce854330600fb.tar.gz gdb-9eb1356e381f3412f53ffe5bc68ce854330600fb.tar.bz2 | |
Revert union gdb_sockaddr_u
This reverts 366c75fc.
We don't actually need to access the object through
"struct sockaddr *", so we don't need the union:
https://sourceware.org/ml/gdb-patches/2015-03/msg00213.html
gdb/ChangeLog:
2015-03-09 Pedro Alves <palves@redhat.com>
Revert:
2015-03-07 Pedro Alves <palves@redhat.com>
* common/gdb_socket.h: New file.
* ser-tcp.c: Include gdb_socket.h. Don't include netinet/in.h nor
sys/socket.h.
(net_open): Use union gdb_sockaddr_u.
gdb/gdbserver/ChangeLog:
2015-03-09 Pedro Alves <palves@redhat.com>
Revert:
2015-03-07 Pedro Alves <palves@redhat.com>
* gdbreplay.c: No longer include <netinet/in.h>, <sys/socket.h>,
or <winsock2.h> here. Instead include "gdb_socket.h".
(remote_open): Use union gdb_sockaddr_u.
* remote-utils.c: No longer include <netinet/in.h>, <sys/socket.h>
or <winsock2.h> here. Instead include "gdb_socket.h".
(handle_accept_event, remote_prepare): Use union gdb_sockaddr_u.
* tracepoint.c: Include "gdb_socket.h" instead of <sys/socket.h>
or <sys/un.h>.
(init_named_socket, gdb_agent_helper_thread): Use union
gdb_sockaddr_u.
Diffstat (limited to 'gdb/common')
| -rw-r--r-- | gdb/common/gdb_socket.h | 43 |
1 files changed, 0 insertions, 43 deletions
diff --git a/gdb/common/gdb_socket.h b/gdb/common/gdb_socket.h deleted file mode 100644 index a670f74..0000000 --- a/gdb/common/gdb_socket.h +++ /dev/null @@ -1,43 +0,0 @@ -/* Copyright (C) 2015 Free Software Foundation, Inc. - - This file is part of GDB. - - This program is free software; you can redistribute it and/or modify - it under the terms of the GNU General Public License as published by - the Free Software Foundation; either version 3 of the License, or - (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU General Public License for more details. - - You should have received a copy of the GNU General Public License - along with this program. If not, see <http://www.gnu.org/licenses/>. */ - -#ifndef GDB_SOCKET_H -#define GDB_SOCKET_H - -#if USE_WIN32API -#include <winsock2.h> -#else -#include <sys/socket.h> -#include <netinet/in.h> -#if HAVE_SYS_UN_H -#include <sys/un.h> -#endif -#endif - -/* Use this union instead of casts between struct sockaddr <-> struct - sockaddr_foo to avoid strict aliasing violations. */ - -union gdb_sockaddr_u -{ - struct sockaddr sa; - struct sockaddr_in sa_in; -#if HAVE_SYS_UN_H - struct sockaddr_un sa_un; -#endif -}; - -#endif /* GDB_SOCKET_H */ |