diff options
| author | Simon Marchi <simon.marchi@ericsson.com> | 2017-06-26 15:08:35 +0200 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@ericsson.com> | 2017-06-26 16:51:17 +0200 |
| commit | 8b5a7a6e8ceb34f8e82aa361ee91ec25e0049774 (patch) | |
| tree | 6e3469fc539fe465ea0a48fad8b6cf8ccd40a059 /gdb/common/diagnostics.h | |
| parent | d1435379df189d1c358ebd9776af8824a9158533 (diff) | |
| download | gdb-8b5a7a6e8ceb34f8e82aa361ee91ec25e0049774.zip gdb-8b5a7a6e8ceb34f8e82aa361ee91ec25e0049774.tar.gz gdb-8b5a7a6e8ceb34f8e82aa361ee91ec25e0049774.tar.bz2 | |
vec: Silence -Wunused-function warnings on clang
clang has a too aggressive (or broken, depends on how you want to see
it) -Wunused-function warning, which is triggered by the functions
defined by DEF_VEC_* but not used in the current source file. Normally,
it won't warn about unused static inline functions defined in header
files, because it's expected that a source file won't use all functions
defined in a header file it includes. However, if the DEF_VEC_* macro
is used in a source file, it considers those functions as defined in the
source file, which leads it to think that we should remove those
functions. It is therefore missing a check to see whether those
functions are resulting from macro expansion. A bug already exists for
that:
https://bugs.llvm.org//show_bug.cgi?id=22712
It's quite easy to silence this warning in a localized way, that is in
the DEF_VEC_* macros.
gdb/ChangeLog:
* common/diagnostics.h: Define macros for GCC.
(DIAGNOSTIC_IGNORE_UNUSED_FUNCTION): New macro.
* common/vec.h: Include diagnostics.h.
(DIAGNOSTIC_IGNORE_UNUSED_VEC_FUNCTION): New macro.
(DEF_VEC_I, DEF_VEC_P, DEF_VEC_O): Ignore -Wunused-function
warning.
Diffstat (limited to 'gdb/common/diagnostics.h')
| -rw-r--r-- | gdb/common/diagnostics.h | 17 |
1 files changed, 15 insertions, 2 deletions
diff --git a/gdb/common/diagnostics.h b/gdb/common/diagnostics.h index 35bacf2..d6ab698 100644 --- a/gdb/common/diagnostics.h +++ b/gdb/common/diagnostics.h @@ -31,13 +31,26 @@ # define DIAGNOSTIC_IGNORE(option) #endif -#ifdef __clang__ +#if defined (__clang__) /* clang */ + # define DIAGNOSTIC_IGNORE_SELF_MOVE DIAGNOSTIC_IGNORE ("-Wself-move") # define DIAGNOSTIC_IGNORE_DEPRECATED_REGISTER \ DIAGNOSTIC_IGNORE ("-Wdeprecated-register") -#else +# define DIAGNOSTIC_IGNORE_UNUSED_FUNCTION \ + DIAGNOSTIC_IGNORE ("-Wunused-function") + +#elif defined (__GNUC__) /* GCC */ + +# define DIAGNOSTIC_IGNORE_SELF_MOVE +# define DIAGNOSTIC_IGNORE_DEPRECATED_REGISTER +# define DIAGNOSTIC_IGNORE_UNUSED_FUNCTION \ + DIAGNOSTIC_IGNORE ("-Wunused-function") + +#else /* Other compilers */ + # define DIAGNOSTIC_IGNORE_SELF_MOVE # define DIAGNOSTIC_IGNORE_DEPRECATED_REGISTER +# define DIAGNOSTIC_IGNORE_UNUSED_FUNCTION #endif #endif /* COMMON_DIAGNOSTICS_H */ |