diff options
| author | Simon Marchi <simon.marchi@efficios.com> | 2020-05-21 13:12:29 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@efficios.com> | 2020-05-21 13:12:29 -0400 |
| commit | 84d53fa9d281f057af5916f8663bc9a2872c5f6e (patch) | |
| tree | f6b7498d254e80fcd821b61642ff3f834be7953c /gdb/coffread.c | |
| parent | 0490dd41ae89e66efd8b3cee122c189a481269de (diff) | |
| download | gdb-84d53fa9d281f057af5916f8663bc9a2872c5f6e.zip gdb-84d53fa9d281f057af5916f8663bc9a2872c5f6e.tar.gz gdb-84d53fa9d281f057af5916f8663bc9a2872c5f6e.tar.bz2 | |
gdb: remove unnecessary NULL checks before xfree
I was inspired by a series of patches merged by Alan Modra in the other
projects, so I did the same in GDB with a bit of Coccinelle and grep.
This patch removes the unnecessary NULL checks before calls to xfree.
They are unnecessary because xfree already does a NULL check. Since
free is supposed to handle NULL values correctly, the NULL check in
xfree itself is also questionable, but I've left it there for now.
gdb/ChangeLog:
* coffread.c (patch_type): Remove NULL check before xfree.
* corefile.c (set_gnutarget): Likewise.
* cp-abi.c (set_cp_abi_as_auto_default): Likewise.
* exec.c (build_section_table): Likewise.
* remote.c (remote_target::pass_signals): Likewise.
* utils.c (n_spaces): Likewise.
* cli/cli-script.c (document_command): Likewise.
* i386-windows-tdep.c (core_process_module_section): Likewise.
* linux-fork.c (struct fork_info) <~fork_info>: Likewise.
Diffstat (limited to 'gdb/coffread.c')
| -rw-r--r-- | gdb/coffread.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/gdb/coffread.c b/gdb/coffread.c index fc44e53..0f7a6e3 100644 --- a/gdb/coffread.c +++ b/gdb/coffread.c @@ -1467,8 +1467,7 @@ patch_type (struct type *type, struct type *real_type) { /* The previous copy of TYPE_NAME is allocated by process_coff_symbol. */ - if (target->name ()) - xfree ((char*) target->name ()); + xfree ((char *) target->name ()); target->set_name (xstrdup (real_target->name ())); } } |