diff options
| author | Simon Marchi <simon.marchi@efficios.com> | 2020-06-08 15:26:04 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@efficios.com> | 2020-06-08 15:26:04 -0400 |
| commit | 5d14b6e5d6525ce462c30501644922a10f8682eb (patch) | |
| tree | 0f1ce729b9393dc161bbcc4fc70f5b7b0a3ff335 /gdb/coffread.c | |
| parent | 3d967001ecd3b325fc39d7f53ebf7054d1ecd503 (diff) | |
| download | gdb-5d14b6e5d6525ce462c30501644922a10f8682eb.zip gdb-5d14b6e5d6525ce462c30501644922a10f8682eb.tar.gz gdb-5d14b6e5d6525ce462c30501644922a10f8682eb.tar.bz2 | |
gdb: add field::type / field::set_type
Add the `type` and `set_type` methods on `struct field`, in order to
remoremove the `FIELD_TYPE` macro. In this patch, the `FIELD_TYPE`
macro is changed to use `field::type`, so all the call sites that are
useused to set the field's type are changed to use `field::set_type`.
The next patch will remove `FIELD_TYPE` completely.
Note that because of the name clash between the existing field named
`type` and the new method, I renamed the field `m_type`. It is not
private per-se, because we can't make `struct field` a non-POD yet, but
it should be considered private anyway (not accessed outside `struct
field`).
gdb/ChangeLog:
* gdbtypes.h (struct field) <type, set_type>: New methods.
Rename `type` field to...
<m_type>: ... this. Change references throughout to use type or
set_type methods.
(FIELD_TYPE): Use field::type. Change call sites that modify
the field's type to use field::set_type instead.
Change-Id: Ie21f866e3b7f8a51ea49b722d07d272a724459a0
Diffstat (limited to 'gdb/coffread.c')
| -rw-r--r-- | gdb/coffread.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/gdb/coffread.c b/gdb/coffread.c index 8b1f040..1592dc6 100644 --- a/gdb/coffread.c +++ b/gdb/coffread.c @@ -2008,8 +2008,8 @@ coff_read_struct_type (int index, int length, int lastsym, /* Save the data. */ list->field.name = obstack_strdup (&objfile->objfile_obstack, name); - FIELD_TYPE (list->field) = decode_type (ms, ms->c_type, - &sub_aux, objfile); + list->field.set_type (decode_type (ms, ms->c_type, &sub_aux, + objfile)); SET_FIELD_BITPOS (list->field, 8 * ms->c_value); FIELD_BITSIZE (list->field) = 0; nfields++; @@ -2024,8 +2024,8 @@ coff_read_struct_type (int index, int length, int lastsym, /* Save the data. */ list->field.name = obstack_strdup (&objfile->objfile_obstack, name); - FIELD_TYPE (list->field) = decode_type (ms, ms->c_type, - &sub_aux, objfile); + list->field.set_type (decode_type (ms, ms->c_type, &sub_aux, + objfile)); SET_FIELD_BITPOS (list->field, ms->c_value); FIELD_BITSIZE (list->field) = sub_aux.x_sym.x_misc.x_lnsz.x_size; nfields++; |