diff options
| author | Simon Marchi <simon.marchi@polymtl.ca> | 2021-04-26 11:27:07 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2021-04-26 11:27:07 -0400 |
| commit | bea3329b76cf131ad4ac27acb6728b38984998b9 (patch) | |
| tree | 5c8d8482d6ec1da893061e2e263a55a2fff28a71 /gdb/cli | |
| parent | 21f91785752b59d03117f7803b7e1c9a58e62dbe (diff) | |
| download | gdb-bea3329b76cf131ad4ac27acb6728b38984998b9.zip gdb-bea3329b76cf131ad4ac27acb6728b38984998b9.tar.gz gdb-bea3329b76cf131ad4ac27acb6728b38984998b9.tar.bz2 | |
gdb: check result of gdb_fopen_cloexec in dump_binary_file
Bug 27773 shows that passing a filename in a non-existent directory to
the "dump binary" command leads to a gdb crash. This is because the
gdb_fopen_cloexec in dump_binary_file fails (returns nullptr) and the
return value is not checked. Fix that by erroring out if
gdb_fopen_cloexec fails.
gdb/ChangeLog:
PR gdb/27773
* cli/cli-dump.c (dump_binary_file): Check result of
gdb_fopen_cloexec.
gdb/testsuite/ChangeLog:
PR gdb/27773
* gdb.base/dump.exp: Test dump to non-existent dir.
Change-Id: Iea89a3bf9e6b9dcc31142faa5ae17bc855759328
Diffstat (limited to 'gdb/cli')
| -rw-r--r-- | gdb/cli/cli-dump.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/gdb/cli/cli-dump.c b/gdb/cli/cli-dump.c index ee3ce03..1df2662 100644 --- a/gdb/cli/cli-dump.c +++ b/gdb/cli/cli-dump.c @@ -135,6 +135,9 @@ dump_binary_file (const char *filename, const char *mode, int status; gdb_file_up file = gdb_fopen_cloexec (filename, mode); + if (file == nullptr) + perror_with_name (filename); + status = fwrite (buf, len, 1, file.get ()); if (status != 1) perror_with_name (filename); |