diff options
| author | Pedro Alves <palves@redhat.com> | 2016-04-14 12:58:03 +0100 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2016-04-14 12:59:01 +0100 |
| commit | 7f31862a8d9f3eea51fc58bd66abeb70c730feaf (patch) | |
| tree | a177853f4bb0f6edf4dc90915f20c024bf248e0e /gdb/cli | |
| parent | aebf07fc1483b0bda9bbc1c0b7d7184b7e840677 (diff) | |
| download | gdb-7f31862a8d9f3eea51fc58bd66abeb70c730feaf.zip gdb-7f31862a8d9f3eea51fc58bd66abeb70c730feaf.tar.gz gdb-7f31862a8d9f3eea51fc58bd66abeb70c730feaf.tar.bz2 | |
Avoid "format not a string literal" warnings
On:
$ uname -a
NetBSD gcc70.fsffrance.org 5.1 NetBSD 5.1 (GENERIC) #0: Sat Nov 6 13:19:33 UTC 2010 builds@b6.netbsd.org:/home/builds/ab/netbsd-5-1-RELEASE/amd64/201011061943Z-obj/home/builds/ab/netbsd-5-1-RELEASE/src/sys/arch/amd64/compile/GENERIC amd64
With:
$ g++ -v
Using built-in specs.
Target: x86_64--netbsd
Configured with: /usr/src/tools/gcc/../../gnu/dist/gcc4/configure --enable-long-long --disable-multilib --enable-threads --disable-symvers --build=x86_64-unknown-netbsd4.99.72 --host=x86_64--netbsd --target=x86_64--netbsd --enable-__cxa_atexit
Thread model: posix
gcc version 4.1.3 20080704 prerelease (NetBSD nb2 20081120)
I saw:
cc1plus: warnings being treated as errors
../../src/gdb/ctf.c: In function 'void ctf_save_metadata_header(trace_write_handler*)':
../../src/gdb/ctf.c:267: warning: format not a string literal, argument types not checked
cc1plus: warnings being treated as errors
../../src/gdb/cli/cli-cmds.c: In function 'void alias_command(char*, int)':
../../src/gdb/cli/cli-cmds.c:1428: warning: format not a string literal and no format arguments
../../src/gdb/cli/cli-cmds.c:1457: warning: format not a string literal and no format arguments
gdb/ChangeLog:
2016-04-14 Pedro Alves <palves@redhat.com>
* cli/cli-cmds.c (alias_usage_error): New function.
(alias_command): Use it.
* ctf.c (ctf_save_metadata_header): Inline metadata_fmt local in
ctf_save_write_metadata call.
Diffstat (limited to 'gdb/cli')
| -rw-r--r-- | gdb/cli/cli-cmds.c | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c index ede4909..c60b1d3 100644 --- a/gdb/cli/cli-cmds.c +++ b/gdb/cli/cli-cmds.c @@ -1410,6 +1410,14 @@ valid_command_p (const char *command) return *command == '\0'; } +/* Called when "alias" was incorrectly used. */ + +static void +alias_usage_error (void) +{ + error (_("Usage: alias [-a] [--] ALIAS = COMMAND")); +} + /* Make an alias of an existing command. */ static void @@ -1421,10 +1429,9 @@ alias_command (char *args, int from_tty) char **alias_argv, **command_argv; dyn_string_t alias_dyn_string, command_dyn_string; struct cleanup *cleanup; - static const char usage[] = N_("Usage: alias [-a] [--] ALIAS = COMMAND"); if (args == NULL || strchr (args, '=') == NULL) - error (_(usage)); + alias_usage_error (); args2 = xstrdup (args); cleanup = make_cleanup (xfree, args2); @@ -1453,7 +1460,7 @@ alias_command (char *args, int from_tty) if (alias_argv[0] == NULL || command_argv[0] == NULL || *alias_argv[0] == '\0' || *command_argv[0] == '\0') - error (_(usage)); + alias_usage_error (); for (i = 0; alias_argv[i] != NULL; ++i) { |