diff options
| author | Tom Tromey <tromey@adacore.com> | 2019-06-25 12:50:45 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2019-10-02 09:53:17 -0600 |
| commit | 4b610737f02338b2aea7641ab771aa5e137d067c (patch) | |
| tree | a29d17f55e269ad24027060bb9fb0bdf40cd3b67 /gdb/ChangeLog | |
| parent | 1dd588507782591478882a891f64945af9e2b86c (diff) | |
| download | gdb-4b610737f02338b2aea7641ab771aa5e137d067c.zip gdb-4b610737f02338b2aea7641ab771aa5e137d067c.tar.gz gdb-4b610737f02338b2aea7641ab771aa5e137d067c.tar.bz2 | |
Handle copy relocations
In ELF, if a data symbol is defined in a shared library and used by
the main program, it will be subject to a "copy relocation". In this
scenario, the main program has a copy of the symbol in question, and a
relocation that tells ld.so to copy the data from the shared library.
Then the symbol in the main program is used to satisfy all references.
This patch changes gdb to handle this scenario. Data symbols coming
from ELF shared libraries get a special flag that indicates that the
symbol's address may be subject to copy relocation.
I looked briefly into handling copy relocations by looking at the
actual relocations in the main program, but this seemed difficult to
do with BFD.
Note that no caching is done here. Perhaps this could be changed if
need be; I wanted to avoid possible problems with either objfile
lifetimes and changes, or conflicts with the long-term (vapor-ware)
objfile splitting project.
gdb/ChangeLog
2019-10-02 Tom Tromey <tromey@adacore.com>
* symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
* ada-lang.c (lesseq_defined_than): Handle
LOC_STATIC.
* dwarf2read.c (dwarf2_per_objfile): Add can_copy
parameter.
(dwarf2_has_info): Likewise.
(new_symbol): Set maybe_copied on symbol when
appropriate.
* dwarf2read.h (dwarf2_per_objfile): Add can_copy
parameter.
<can_copy>: New member.
* elfread.c (record_minimal_symbol): Set maybe_copied
on symbol when appropriate.
(elf_symfile_read): Update call to dwarf2_has_info.
* minsyms.c (lookup_minimal_symbol_linkage): New
function.
* minsyms.h (lookup_minimal_symbol_linkage): Declare.
* symtab.c (get_symbol_address, get_msymbol_address):
New functions.
* symtab.h (get_symbol_address, get_msymbol_address):
Declare.
(SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
maybe_copied.
(struct symbol, struct minimal_symbol) <maybe_copied>:
New member.
Diffstat (limited to 'gdb/ChangeLog')
| -rw-r--r-- | gdb/ChangeLog | 28 |
1 files changed, 28 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index bf2811a..9bfb755 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,33 @@ 2019-10-02 Tom Tromey <tromey@adacore.com> + * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS. + * ada-lang.c (lesseq_defined_than): Handle + LOC_STATIC. + * dwarf2read.c (dwarf2_per_objfile): Add can_copy + parameter. + (dwarf2_has_info): Likewise. + (new_symbol): Set maybe_copied on symbol when + appropriate. + * dwarf2read.h (dwarf2_per_objfile): Add can_copy + parameter. + <can_copy>: New member. + * elfread.c (record_minimal_symbol): Set maybe_copied + on symbol when appropriate. + (elf_symfile_read): Update call to dwarf2_has_info. + * minsyms.c (lookup_minimal_symbol_linkage): New + function. + * minsyms.h (lookup_minimal_symbol_linkage): Declare. + * symtab.c (get_symbol_address, get_msymbol_address): + New functions. + * symtab.h (get_symbol_address, get_msymbol_address): + Declare. + (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle + maybe_copied. + (struct symbol, struct minimal_symbol) <maybe_copied>: + New member. + +2019-10-02 Tom Tromey <tromey@adacore.com> + * source.c (struct current_source_location): New. (current_source_key): New global. (current_source_symtab, current_source_line) |