diff options
| author | Simon Marchi <simon.marchi@efficios.com> | 2020-03-16 16:56:36 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2020-03-16 16:56:36 -0400 |
| commit | 30efb6c7af7ad8b50936157fe0a0ef22d6787dd7 (patch) | |
| tree | 5ab2f17411bcb3088e7b56173fc51449791e68ee /gdb/ChangeLog | |
| parent | 8db52437243e251c01e352cdb325bc9ace578e7c (diff) | |
| download | gdb-30efb6c7af7ad8b50936157fe0a0ef22d6787dd7.zip gdb-30efb6c7af7ad8b50936157fe0a0ef22d6787dd7.tar.gz gdb-30efb6c7af7ad8b50936157fe0a0ef22d6787dd7.tar.bz2 | |
gdb: define builtin long type to be 64 bits on amd64 Cygwin
On Windows x86-64 (when building with MinGW), the size of the "long"
type is 32 bits. amd64_windows_init_abi therefore does:
set_gdbarch_long_bit (gdbarch, 32);
This is also used when the chosen OS ABI is Cygwin, where the "long"
type is 64 bits. GDB therefore gets sizeof(long) wrong when using the
builtin long type:
$ ./gdb -nx --data-directory=data-directory -batch -ex "set architecture i386:x86-64" -ex "set osabi Cygwin" -ex "print sizeof(long)"
The target architecture is assumed to be i386:x86-64
$1 = 4
This patch makes GDB avoid setting the size of the long type to 32 bits
when using the Cygwin OS ABI. it will inherit the value set in
amd64_init_abi.
With this patch, I get:
$ ./gdb -nx --data-directory=data-directory -batch -ex "set architecture i386:x86-64" -ex "set osabi Cygwin" -ex "print sizeof(long)"
The target architecture is assumed to be i386:x86-64
$1 = 8
gdb/ChangeLog:
PR gdb/21500
* amd64-windows-tdep.c (amd64_windows_init_abi): Rename
to...
(amd64_windows_init_abi_common): ... this. Don't set size of
long type.
(amd64_windows_init_abi): New function.
(amd64_cygwin_init_abi): New function.
(_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
the Cygwin OS ABI.
* i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
comment.
Diffstat (limited to 'gdb/ChangeLog')
| -rw-r--r-- | gdb/ChangeLog | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 68c8bf7..6cb3cb5 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,19 @@ 2020-03-16 Simon Marchi <simon.marchi@efficios.com> + PR gdb/21500 + * amd64-windows-tdep.c (amd64_windows_init_abi): Rename + to... + (amd64_windows_init_abi_common): ... this. Don't set size of + long type. + (amd64_windows_init_abi): New function. + (amd64_cygwin_init_abi): New function. + (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for + the Cygwin OS ABI. + * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify + comment. + +2020-03-16 Simon Marchi <simon.marchi@efficios.com> + * windows-tdep.h (is_linked_with_cygwin_dll): New declaration. * windows-tdep.c (CYGWIN_DLL_NAME): New. (pe_import_directory_entry): New struct type. |