diff options
| author | Andrew Burgess <andrew.burgess@embecosm.com> | 2019-07-01 16:00:52 +0100 |
|---|---|---|
| committer | Andrew Burgess <andrew.burgess@embecosm.com> | 2019-07-09 10:31:20 +0100 |
| commit | 0ba852ab4126a6eb4be88577d62dc25f2be7f725 (patch) | |
| tree | 0ef80118d4c8ea5beace2189699ffb5dd3714334 /gdb/ChangeLog | |
| parent | b3a7d1711e4557811865333a0ac96fc16b750869 (diff) | |
| download | gdb-0ba852ab4126a6eb4be88577d62dc25f2be7f725.zip gdb-0ba852ab4126a6eb4be88577d62dc25f2be7f725.tar.gz gdb-0ba852ab4126a6eb4be88577d62dc25f2be7f725.tar.bz2 | |
gdb: Remove unneeded parameter from set_breakpoint_location_function
The explicit_loc parameter in set_breakpoint_location_function is not
useful. This parameter is set from two possible fields of the
symtab_and_line used to create the breakpoint; the explicit_pc field,
and the explicit_line field.
First, the explicit_line field, this is not currently set for any
breakpoint command, so will never be true.
Next, the explicit_pc field. This can be true but will never be true
at the same time that the sal->msymbol field is also true - the
sal->msymbol is only ever set in linespec.c:minsym_found, which
doesn't allow for explicitly setting the pc.
The result of this is that if we are setting a breakpoint on an
msymbol that could turn out to be an ifunc, then we will not also have
either an explicit_pc or an explicit_line, this check can therefore be
removed.
There should be no user visible changes after this commit.
gdb/ChangeLog:
* breakpoint.c (set_breakpoint_location_function): Remove
explicit_loc parameter.
(momentary_breakpoint_from_master): Update call to
set_breakpoint_location_function.
(add_location_to_breakpoint): Likewise.
Diffstat (limited to 'gdb/ChangeLog')
| -rw-r--r-- | gdb/ChangeLog | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 854eeb5..2fef7d2 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,13 @@ 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com> + * breakpoint.c (set_breakpoint_location_function): Remove + explicit_loc parameter. + (momentary_breakpoint_from_master): Update call to + set_breakpoint_location_function. + (add_location_to_breakpoint): Likewise. + +2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com> + * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify required features based on default bfd type when no specific bfd is present. |