diff options
author | Andrew Burgess <andrew.burgess@embecosm.com> | 2021-02-09 21:41:30 +0000 |
---|---|---|
committer | Andrew Burgess <andrew.burgess@embecosm.com> | 2021-02-09 21:46:12 +0000 |
commit | 03642b7189bc0bfdf61354a6d9a3f3e46d82709c (patch) | |
tree | 4c18b49e25fceaab1b1a658fc868b55d61d4387f /gdb/ChangeLog | |
parent | b61f78118a850a28a41a461fdaea4026ddc17658 (diff) | |
download | gdb-03642b7189bc0bfdf61354a6d9a3f3e46d82709c.zip gdb-03642b7189bc0bfdf61354a6d9a3f3e46d82709c.tar.gz gdb-03642b7189bc0bfdf61354a6d9a3f3e46d82709c.tar.bz2 |
gdb: revert "gdb: unify parts of the Linux and FreeBSD core dumping code"
This reverts commit 82a1fd3a4935fe665cf08bc6820942c4a091184c.
It was pointed out:
https://sourceware.org/pipermail/gdb-patches/2021-February/175750.html
that commit 82a1fd3a4935 caused GDB to have an unconditional
dependency on ELF specific parts of BFD. What this means is that if
GDB and BFD are built for a non-elf target then there will be
undefined symbol references within GDB.
The right solution isn't immediately obvious. So rather than rush a
fix in I'm reverting this commit for now, and will bring it back once
I have a good solution.
gdb/ChangeLog:
* gcore.c (struct gcore_collect_regset_section_cb_data): Delete.
(gcore_collect_regset_section_cb): Delete.
(gcore_collect_thread_registers): Delete.
(gcore_build_thread_register_notes): Delete.
(gcore_find_signalled_thread): Delete.
* gcore.h: Remove 'gdbsupport/gdb_signals.h' include and delete
'gdbarch' and 'thread_info' declarations.
(gcore_build_thread_register_notes): Delete declaration.
(gcore_find_signalled_thread): Likewise.
* fbsd-tdep.c: Remove 'gcore.h' include.
(struct fbsd_collect_regset_section_cb_data): New struct.
(fbsd_collect_regset_section_cb): New function.
(fbsd_collect_thread_registers): New function.
(struct fbsd_corefile_thread_data): New struct.
(fbsd_corefile_thread): New function.
(fbsd_make_corefile_notes): Call FreeBSD specific code.
* linux-tdep.c: Remove 'gcore.h' include.
(struct linux_collect_regset_section_cb_data): New struct.
(linux_collect_regset_section_cb): New function.
(linux_collect_thread_registers): New function.
(linux_corefile_thread): Call Linux specific code.
(find_signalled_thread): New function.
(linux_make_corefile_notes): Call find_signalled_thread.
Diffstat (limited to 'gdb/ChangeLog')
-rw-r--r-- | gdb/ChangeLog | 26 |
1 files changed, 26 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5c66f99..220ef2a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,29 @@ +2021-02-09 Andrew Burgess <andrew.burgess@embecosm.com> + + * gcore.c (struct gcore_collect_regset_section_cb_data): Delete. + (gcore_collect_regset_section_cb): Delete. + (gcore_collect_thread_registers): Delete. + (gcore_build_thread_register_notes): Delete. + (gcore_find_signalled_thread): Delete. + * gcore.h: Remove 'gdbsupport/gdb_signals.h' include and delete + 'gdbarch' and 'thread_info' declarations. + (gcore_build_thread_register_notes): Delete declaration. + (gcore_find_signalled_thread): Likewise. + * fbsd-tdep.c: Remove 'gcore.h' include. + (struct fbsd_collect_regset_section_cb_data): New struct. + (fbsd_collect_regset_section_cb): New function. + (fbsd_collect_thread_registers): New function. + (struct fbsd_corefile_thread_data): New struct. + (fbsd_corefile_thread): New function. + (fbsd_make_corefile_notes): Call FreeBSD specific code. + * linux-tdep.c: Remove 'gcore.h' include. + (struct linux_collect_regset_section_cb_data): New struct. + (linux_collect_regset_section_cb): New function. + (linux_collect_thread_registers): New function. + (linux_corefile_thread): Call Linux specific code. + (find_signalled_thread): New function. + (linux_make_corefile_notes): Call find_signalled_thread. + 2021-02-09 Tom Tromey <tromey@adacore.com> * ada-lang.c (coerce_unspec_val_to_type): Avoid making lazy |