diff options
author | H.J. Lu <hjl.tools@gmail.com> | 2024-12-02 12:58:33 +0800 |
---|---|---|
committer | Haochen Jiang <haochen.jiang@intel.com> | 2024-12-05 09:57:59 +0800 |
commit | 4c0a6e603743ca0c85f9ceb9913d646f0c961986 (patch) | |
tree | 37799a7269037d2b00183076c7709c7c1288ec34 /gas/testsuite | |
parent | e998ba604f8b1498c8ad43f2c19fee097b6131ef (diff) | |
download | gdb-4c0a6e603743ca0c85f9ceb9913d646f0c961986.zip gdb-4c0a6e603743ca0c85f9ceb9913d646f0c961986.tar.gz gdb-4c0a6e603743ca0c85f9ceb9913d646f0c961986.tar.bz2 |
x86: Eliminate unnecessary {evex} prefixes
For several instructions including vps{l,r}l{d,q,w,dq} and vpsra{d,w},
their VEX part do not have the following version:
vpsrlw $0x1f,(%r15,%rcx,4),%xmm0
Thus, {evex} prefix should not be inserted when their second operand is
memory, while we still need them for register as second operand. Add a
new macro %ME to solve this problem.
For vpsraq, there is no VEX version, so the {evex} prefix should always
be eliminated.
gas/ChangeLog:
PR binutils/32403
* testsuite/gas/i386/i386.exp: Run new test.
* testsuite/gas/i386/x86-64.exp: Ditto.
* testsuite/gas/i386/evex-only.d: New test.
* testsuite/gas/i386/evex-only.s: Ditto.
* testsuite/gas/i386/x86-64-evex-only.d: Ditto.
* testsuite/gas/i386/x86-64-evex-only.s: Ditto.
opcodes/ChangeLog:
PR binutils/32403
* i386-dis-evex-reg.h: Use %ME instead of %XE for vps{l,r}l{w,dq}
and vpsraw. Split table for vpsra{d,q}.
* i386-dis-evex-w.h: Use %ME instead of %XE for vps{l,r}l{d,q}
and vpsrad. Eliminate vpsraq {evex} prefix.
* i386-dis-evex.h: Split table for vpsra{d,q}.
* i386-dis.c: (EVEX_W_0F72_R_4): New.
(EVEX_W_0FE2): Ditto.
(struct dis386): Add comment for %ME.
(putop): Handle %ME.
Co-authored-by: Haochen Jiang <haochen.jiang@intel.com>
Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
Diffstat (limited to 'gas/testsuite')
-rw-r--r-- | gas/testsuite/gas/i386/evex-only.d | 24 | ||||
-rw-r--r-- | gas/testsuite/gas/i386/evex-only.s | 18 | ||||
-rw-r--r-- | gas/testsuite/gas/i386/i386.exp | 1 | ||||
-rw-r--r-- | gas/testsuite/gas/i386/x86-64-evex-only.d | 24 | ||||
-rw-r--r-- | gas/testsuite/gas/i386/x86-64-evex-only.s | 18 | ||||
-rw-r--r-- | gas/testsuite/gas/i386/x86-64.exp | 1 |
6 files changed, 86 insertions, 0 deletions
diff --git a/gas/testsuite/gas/i386/evex-only.d b/gas/testsuite/gas/i386/evex-only.d new file mode 100644 index 0000000..373715d --- /dev/null +++ b/gas/testsuite/gas/i386/evex-only.d @@ -0,0 +1,24 @@ +#objdump: -dw +#name: AVX512 instructions do not need {evex} prefix with memory + +.*: +file format .* + + +Disassembly of section .text: + +0+ <_start>: +\s*[a-f0-9]+:\s*62 f1 7d 08 71 14 88 1f\s+vpsrlw\s+\$0x1f,\(%eax,%ecx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 f1 7d 08 71 24 88 1f\s+vpsraw\s+\$0x1f,\(%eax,%ecx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 f1 7d 08 71 34 88 1f\s+vpsllw\s+\$0x1f,\(%eax,%ecx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 f1 7d 08 72 24 88 1f\s+vpsrad\s+\$0x1f,\(%eax,%ecx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 f1 fd 08 72 24 88 1f\s+vpsraq\s+\$0x1f,\(%eax,%ecx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 f1 fd 08 72 e1 1f\s+vpsraq\s+\$0x1f,%xmm1,%xmm0 +\s*[a-f0-9]+:\s*62 f1 f5 08 e2 04 88\s+vpsraq\s+\(%eax,%ecx,4\),%xmm1,%xmm0 +\s*[a-f0-9]+:\s*62 f1 f5 08 e2 c2\s+vpsraq\s+%xmm2,%xmm1,%xmm0 +\s*[a-f0-9]+:\s*62 f1 7d 08 73 1c 88 1f\s+vpsrldq\s+\$0x1f,\(%eax,%ecx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 f1 7d 08 73 3c 88 1f\s+vpslldq\s+\$0x1f,\(%eax,%ecx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 f1 7d 08 72 14 88 1f\s+vpsrld\s+\$0x1f,\(%eax,%ecx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 f1 7d 08 72 34 88 1f\s+vpslld\s+\$0x1f,\(%eax,%ecx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 f1 fd 08 73 14 88 1f\s+vpsrlq\s+\$0x1f,\(%eax,%ecx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 f1 fd 08 73 34 88 1f\s+vpsllq\s+\$0x1f,\(%eax,%ecx,4\),%xmm0 +#pass diff --git a/gas/testsuite/gas/i386/evex-only.s b/gas/testsuite/gas/i386/evex-only.s new file mode 100644 index 0000000..e198c19 --- /dev/null +++ b/gas/testsuite/gas/i386/evex-only.s @@ -0,0 +1,18 @@ +# Check instructions do not need {evex} prefix under memory operand + + .text +_start: + vpsrlw $0x1f,(%eax,%ecx,4),%xmm0 + vpsraw $0x1f,(%eax,%ecx,4),%xmm0 + vpsllw $0x1f,(%eax,%ecx,4),%xmm0 + vpsrad $0x1f,(%eax,%ecx,4),%xmm0 + vpsraq $0x1f,(%eax,%ecx,4),%xmm0 + vpsraq $0x1f,%xmm1,%xmm0 + vpsraq (%eax,%ecx,4),%xmm1,%xmm0 + vpsraq %xmm2,%xmm1,%xmm0 + vpsrldq $0x1f,(%eax,%ecx,4),%xmm0 + vpslldq $0x1f,(%eax,%ecx,4),%xmm0 + vpsrld $0x1f,(%eax,%ecx,4),%xmm0 + vpslld $0x1f,(%eax,%ecx,4),%xmm0 + vpsrlq $0x1f,(%eax,%ecx,4),%xmm0 + vpsllq $0x1f,(%eax,%ecx,4),%xmm0 diff --git a/gas/testsuite/gas/i386/i386.exp b/gas/testsuite/gas/i386/i386.exp index 64e029e..3a79049 100644 --- a/gas/testsuite/gas/i386/i386.exp +++ b/gas/testsuite/gas/i386/i386.exp @@ -294,6 +294,7 @@ if [gas_32_check] then { run_dump_test "evex-lig-2" run_dump_test "evex-wig1" run_dump_test "evex-wig1-intel" + run_dump_test "evex-only" run_dump_test "evex-no-scale-32" run_dump_test "sse2avx" run_dump_test "unaligned-vector-move" diff --git a/gas/testsuite/gas/i386/x86-64-evex-only.d b/gas/testsuite/gas/i386/x86-64-evex-only.d new file mode 100644 index 0000000..16565b8 --- /dev/null +++ b/gas/testsuite/gas/i386/x86-64-evex-only.d @@ -0,0 +1,24 @@ +#objdump: -dw +#name: x86-64 AVX512 instructions do not need {evex} prefix with memory + +.*: +file format .* + + +Disassembly of section .text: + +0+ <_start>: +\s*[a-f0-9]+:\s*62 d1 7d 08 71 14 8f 1f\s+vpsrlw\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 7d 08 71 24 8f 1f\s+vpsraw\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 7d 08 71 34 8f 1f\s+vpsllw\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 7d 08 72 24 8f 1f\s+vpsrad\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 fd 08 72 24 8f 1f\s+vpsraq\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 f1 fd 08 72 e1 1f\s+vpsraq\s+\$0x1f,%xmm1,%xmm0 +\s*[a-f0-9]+:\s*62 d1 f5 08 e2 04 8f\s+vpsraq\s+\(%r15,%rcx,4\),%xmm1,%xmm0 +\s*[a-f0-9]+:\s*62 f1 f5 08 e2 c2\s+vpsraq\s+%xmm2,%xmm1,%xmm0 +\s*[a-f0-9]+:\s*62 d1 7d 08 73 1c 8f 1f\s+vpsrldq\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 7d 08 73 3c 8f 1f\s+vpslldq\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 7d 08 72 14 8f 1f\s+vpsrld\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 7d 08 72 34 8f 1f\s+vpslld\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 fd 08 73 14 8f 1f\s+vpsrlq\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +\s*[a-f0-9]+:\s*62 d1 fd 08 73 34 8f 1f\s+vpsllq\s+\$0x1f,\(%r15,%rcx,4\),%xmm0 +#pass diff --git a/gas/testsuite/gas/i386/x86-64-evex-only.s b/gas/testsuite/gas/i386/x86-64-evex-only.s new file mode 100644 index 0000000..f8024fd --- /dev/null +++ b/gas/testsuite/gas/i386/x86-64-evex-only.s @@ -0,0 +1,18 @@ +# Check instructions do not need {evex} prefix under memory operand + + .text +_start: + vpsrlw $0x1f,(%r15,%rcx,4),%xmm0 + vpsraw $0x1f,(%r15,%rcx,4),%xmm0 + vpsllw $0x1f,(%r15,%rcx,4),%xmm0 + vpsrad $0x1f,(%r15,%rcx,4),%xmm0 + vpsraq $0x1f,(%r15,%rcx,4),%xmm0 + vpsraq $0x1f,%xmm1,%xmm0 + vpsraq (%r15,%rcx,4),%xmm1,%xmm0 + vpsraq %xmm2,%xmm1,%xmm0 + vpsrldq $0x1f,(%r15,%rcx,4),%xmm0 + vpslldq $0x1f,(%r15,%rcx,4),%xmm0 + vpsrld $0x1f,(%r15,%rcx,4),%xmm0 + vpslld $0x1f,(%r15,%rcx,4),%xmm0 + vpsrlq $0x1f,(%r15,%rcx,4),%xmm0 + vpsllq $0x1f,(%r15,%rcx,4),%xmm0 diff --git a/gas/testsuite/gas/i386/x86-64.exp b/gas/testsuite/gas/i386/x86-64.exp index dcf10df..64b49c9 100644 --- a/gas/testsuite/gas/i386/x86-64.exp +++ b/gas/testsuite/gas/i386/x86-64.exp @@ -242,6 +242,7 @@ run_dump_test "x86-64-evex-lig-2" run_dump_test "x86-64-evex-wig1" run_dump_test "x86-64-evex-wig1-intel" run_dump_test "x86-64-evex-wig2" +run_dump_test "x86-64-evex-only" run_dump_test "evex-no-scale-64" run_dump_test "x86-64-sse2avx" run_dump_test "x86-64-unaligned-vector-move" |