gas signed overflow fixes

	* config/tc-aarch64.c (get_aarch64_insn): Avoid signed overflow.
	* config/tc-metag.c (parse_dalu): Likewise.
	* config/tc-tic4x.c (md_pcrel_from): Likewise.
	* config/tc-tic6x.c (tic6x_output_unwinding): Likewise.
	* config/tc-csky.c (parse_fexp): Use an unsigned char temp buffer.
	Don't use register keyword.  Avoid signed overflow and remove now
	unneccesary char masks.  Formatting.
	* config/tc-ia64.c (operand_match): Don't use shifts to sign extend.
	* config/tc-mep.c (mep_apply_fix): Likewise.
	* config/tc-pru.c (md_apply_fix): Likewise.
	* config/tc-riscv.c (load_const): Likewise.
	* config/tc-nios2.c (md_apply_fix): Likewise.  Don't potentially
	truncate fixup before right shift.  Tidy BFD_RELOC_NIOS2_HIADJ16
	calculation.

1 files changed, 30 insertions, 29 deletions

diff --git a/gas/config/tc-csky.c b/gas/config/tc-csky.c
index 970c72a..6fa6ee5 100644
--- a/gas/config/tc-csky.c
+++ b/gas/config/tc-csky.c
@@ -1777,8 +1777,8 @@ static char *
 parse_fexp (char *s, expressionS *e, unsigned char isdouble, uint64_t *dbnum)
 {
   int length;                       /* Number of chars in an object.  */
-  register char const *err = NULL;  /* Error from scanning float literal.  */
-  char temp[8];
+  const char *err = NULL;           /* Error from scanning float literal.  */
+  unsigned char temp[8];
 
   /* input_line_pointer->1st char of a flonum (we hope!).  */
   input_line_pointer = s;
@@ -1788,9 +1788,9 @@ parse_fexp (char *s, expressionS *e, unsigned char isdouble, uint64_t *dbnum)
     input_line_pointer += 2;
 
   if (isdouble)
-    err = md_atof ('d', temp, &length);
+    err = md_atof ('d', (char *) temp, &length);
   else
-    err = md_atof ('f', temp, &length);
+    err = md_atof ('f', (char *) temp, &length);
   know (length <= 8);
   know (err != NULL || length > 0);
 
@@ -1818,41 +1818,42 @@ parse_fexp (char *s, expressionS *e, unsigned char isdouble, uint64_t *dbnum)
     {
       uint32_t fnum;
       if (target_big_endian)
-	fnum = (((temp[0] << 24) & 0xffffffff)
-		| ((temp[1] << 16) & 0xffffff)
-		| ((temp[2] << 8) & 0xffff)
-		| (temp[3] & 0xff));
+	fnum = (((uint32_t) temp[0] << 24)
+		| (temp[1] << 16)
+		| (temp[2] << 8)
+		| temp[3]);
       else
-	fnum = (((temp[3] << 24) & 0xffffffff)
-			   | ((temp[2] << 16) & 0xffffff)
-			   | ((temp[1] << 8) & 0xffff)
-			   | (temp[0] & 0xff));
-      e->X_add_number = fnum;    }
+	fnum = (((uint32_t) temp[3] << 24)
+		| (temp[2] << 16)
+		| (temp[1] << 8)
+		| temp[0]);
+      e->X_add_number = fnum;
+    }
   else
     {
       if (target_big_endian)
 	{
-	  *dbnum = (((temp[0] << 24) & 0xffffffff)
-		    | ((temp[1] << 16) & 0xffffff)
-		    | ((temp[2] << 8) & 0xffff)
-		    | (temp[3] & 0xff));
+	  *dbnum = (((uint32_t) temp[0] << 24)
+		    | (temp[1] << 16)
+		    | (temp[2] << 8)
+		    | temp[3]);
 	  *dbnum <<= 32;
-	  *dbnum |= (((temp[4] << 24) & 0xffffffff)
-		     | ((temp[5] << 16) & 0xffffff)
-		     | ((temp[6] << 8) & 0xffff)
-		     | (temp[7] & 0xff));
+	  *dbnum |= (((uint32_t) temp[4] << 24)
+		     | (temp[5] << 16)
+		     | (temp[6] << 8)
+		     | temp[7]);
 	}
       else
 	{
-	  *dbnum = (((temp[7] << 24) & 0xffffffff)
-		    | ((temp[6] << 16) & 0xffffff)
-		    | ((temp[5] << 8) & 0xffff)
-		    | (temp[4] & 0xff));
+	  *dbnum = (((uint32_t) temp[7] << 24)
+		    | (temp[6] << 16)
+		    | (temp[5] << 8)
+		    | temp[4]);
 	  *dbnum <<= 32;
-	  *dbnum |= (((temp[3] << 24) & 0xffffffff)
-		     | ((temp[2] << 16) & 0xffffff)
-		     | ((temp[1] << 8) & 0xffff)
-		     | (temp[0] & 0xff));
+	  *dbnum |= (((uint32_t) temp[3] << 24)
+		     | (temp[2] << 16)
+		     | (temp[1] << 8)
+		     | temp[0]);
       }
     }
   return input_line_pointer;