diff options
| author | Nick Clifton <nickc@redhat.com> | 2023-06-30 11:18:42 +0100 |
|---|---|---|
| committer | Nick Clifton <nickc@redhat.com> | 2023-06-30 11:18:42 +0100 |
| commit | 0d1cd7d97835941c046dbb7ec1c83bc7c05779e6 (patch) | |
| tree | c5e1f0bf9a0a016122422d023d33c8620d555d9b /binutils | |
| parent | 7e3ca9a4afcc4ff2960d12eaad35c75a7abb84e9 (diff) | |
| download | gdb-0d1cd7d97835941c046dbb7ec1c83bc7c05779e6.zip gdb-0d1cd7d97835941c046dbb7ec1c83bc7c05779e6.tar.gz gdb-0d1cd7d97835941c046dbb7ec1c83bc7c05779e6.tar.bz2 | |
Prevent an illegal memory access when running the strings program with an excessively lerge minimum string length.
PR 30595
* strings.c (main): Check for an excessively large minimum string length.
Diffstat (limited to 'binutils')
| -rw-r--r-- | binutils/ChangeLog | 6 | ||||
| -rw-r--r-- | binutils/strings.c | 6 |
2 files changed, 12 insertions, 0 deletions
diff --git a/binutils/ChangeLog b/binutils/ChangeLog index bb58bc4..f06aba2 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,9 @@ +2023-06-30 Nick Clifton <nickc@redhat.com> + + PR 30595 + * strings.c (main): Check for an excessively large minimum string + length. + 2023-06-21 Nick Clifton <nickc@redhat.com> * testsuite/lib/binutils-common.exp (prune_warnings_extra): Prune diff --git a/binutils/strings.c b/binutils/strings.c index e2c1ead..f7214fc 100644 --- a/binutils/strings.c +++ b/binutils/strings.c @@ -315,8 +315,14 @@ main (int argc, char **argv) if (s != NULL && *s != 0) fatal (_("invalid integer argument %s"), argv[numeric_opt - 1] + 1); } + if (string_min < 1) fatal (_("invalid minimum string length %d"), string_min); + /* PR 30595: Look for excessive minimum string lengths. + The "(4 * string_min) + 1" is because this is the value + used to allocate space in print_unicode_stream(). */ + else if (string_min == -1U || ((4 * string_min) + 1) == 0) + fatal (_("minimum string length %#x is too big"), string_min); switch (encoding) { |