aboutsummaryrefslogtreecommitdiff
path: root/binutils/readelf.c
diff options
context:
space:
mode:
authorNick Clifton <nickc@redhat.com>2019-08-05 10:40:35 +0100
committerNick Clifton <nickc@redhat.com>2019-08-05 10:40:35 +0100
commite17869db99195849826eaaf5d2d0eb2cfdd7a2a7 (patch)
treef2fa1a8ea84149112d7aba413ece7185ed09ad82 /binutils/readelf.c
parent2b79f3761c834cd217407f75f867f6a761703ab3 (diff)
downloadgdb-e17869db99195849826eaaf5d2d0eb2cfdd7a2a7.zip
gdb-e17869db99195849826eaaf5d2d0eb2cfdd7a2a7.tar.gz
gdb-e17869db99195849826eaaf5d2d0eb2cfdd7a2a7.tar.bz2
Catch potential integer overflow in readelf when processing corrupt binaries.
PR 24829 * readelf.c (apply_relocations): Catch potential integer overflow whilst checking reloc location against section size.
Diffstat (limited to 'binutils/readelf.c')
-rw-r--r--binutils/readelf.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/binutils/readelf.c b/binutils/readelf.c
index b896ad9..e785fde 100644
--- a/binutils/readelf.c
+++ b/binutils/readelf.c
@@ -13366,7 +13366,7 @@ apply_relocations (Filedata * filedata,
}
rloc = start + rp->r_offset;
- if ((rloc + reloc_size) > end || (rloc < start))
+ if (rloc >= end || (rloc + reloc_size) > end || (rloc < start))
{
warn (_("skipping invalid relocation offset 0x%lx in section %s\n"),
(unsigned long) rp->r_offset,