diff options
| author | Alan Modra <amodra@gmail.com> | 2022-06-16 14:48:13 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2022-06-16 15:01:14 +0930 |
| commit | 370426d0da768345fb53683c803d6d5a20558065 (patch) | |
| tree | dc3e9cab9672e0a09b4113ecf0b7365780d07fbc /binutils/objdump.c | |
| parent | 8ad7c8be4b5705a1138f7b2922ab7611e1d61e06 (diff) | |
| download | gdb-370426d0da768345fb53683c803d6d5a20558065.zip gdb-370426d0da768345fb53683c803d6d5a20558065.tar.gz gdb-370426d0da768345fb53683c803d6d5a20558065.tar.bz2 | |
Always free matching vector from bfd_check_format_matches
At least one place calling list_matching_formats failed to free the
"matching" vector from bfd_check_format_matches afterwards. Fix that
by calling free inside list_matching_formats.
binutils/
* bucomm.c (list_matching_formats): Free arg.
* addr2line.c (process_file): Adjust to suit.
* ar.c (open_inarch, ranlib_touch): Likewise.
* coffdump.c (main): Likewise.
* nm.c (display_archive, display_file): Likewise.
* objcopy.c (copy_file): Likewise.
* objdump.c (display_object_bfd): Likewise.
* size.c (display_bfd): Likewise.
* srconv.c (main): Likewise.
ld/
* ldlang.c (load_symbols): Free "matching".
Diffstat (limited to 'binutils/objdump.c')
| -rw-r--r-- | binutils/objdump.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/binutils/objdump.c b/binutils/objdump.c index e8fa8ca..6782405 100644 --- a/binutils/objdump.c +++ b/binutils/objdump.c @@ -5426,7 +5426,6 @@ display_object_bfd (bfd *abfd) { nonfatal (bfd_get_filename (abfd)); list_matching_formats (matching); - free (matching); return; } @@ -5445,10 +5444,7 @@ display_object_bfd (bfd *abfd) nonfatal (bfd_get_filename (abfd)); if (bfd_get_error () == bfd_error_file_ambiguously_recognized) - { - list_matching_formats (matching); - free (matching); - } + list_matching_formats (matching); } static void |