diff options
| author | Alan Modra <amodra@gmail.com> | 2023-03-22 10:13:46 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2023-03-22 10:39:18 +1030 |
| commit | bcefc6be9754d45fb9391993e6daaf01a68d9bd5 (patch) | |
| tree | 67e48bec39218f0ae02f1c616a8ab53337437b36 /bfd | |
| parent | 347ab6177835a74d38b4c14042dc0a0325e6dce7 (diff) | |
| download | gdb-bcefc6be9754d45fb9391993e6daaf01a68d9bd5.zip gdb-bcefc6be9754d45fb9391993e6daaf01a68d9bd5.tar.gz gdb-bcefc6be9754d45fb9391993e6daaf01a68d9bd5.tar.bz2 | |
coff_get_normalized_symtab bfd_release
We can't free "internal" on errors, since bfd_coff_swap_sym_in may
call bfd_alloc. For example, _bfd_XXi_swap_sym_in may even create new
sections, which use bfd_alloc'd memory. If "internal" is freed, all
more recently bfd_alloc'd memory is also freed.
* coffgen.c (coff_get_normalized_symtab): Don't bfd_release on
error.
Diffstat (limited to 'bfd')
| -rw-r--r-- | bfd/coffgen.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/bfd/coffgen.c b/bfd/coffgen.c index 774edf7..0b764b0 100644 --- a/bfd/coffgen.c +++ b/bfd/coffgen.c @@ -1753,10 +1753,7 @@ coff_get_normalized_symtab (bfd *abfd) /* PR 17512: Prevent buffer overrun. */ if (symbol_ptr->u.syment.n_numaux > ((raw_end - 1) - raw_src) / symesz) - { - bfd_release (abfd, internal); - return NULL; - } + return NULL; for (i = 0; i < symbol_ptr->u.syment.n_numaux; |