aboutsummaryrefslogtreecommitdiff
path: root/bfd
diff options
context:
space:
mode:
authorNick Clifton <nickc@redhat.com>2021-04-30 12:11:35 +0100
committerNick Clifton <nickc@redhat.com>2021-04-30 12:11:35 +0100
commitbceb87ef4da7948eb9f39584fb5b4a62f9ed4846 (patch)
treeae2633884fa07dec3bcc5ed5a25e78d29e9de9f0 /bfd
parent5536f0cc62309de740e678da87c11039dd7bfb35 (diff)
downloadgdb-bceb87ef4da7948eb9f39584fb5b4a62f9ed4846.zip
gdb-bceb87ef4da7948eb9f39584fb5b4a62f9ed4846.tar.gz
gdb-bceb87ef4da7948eb9f39584fb5b4a62f9ed4846.tar.bz2
Fix illegal memory access when parsing a corrupt PE format file.
PR 27795 * coff-rs6000.c (_bfd_xcoff_read_ar_hdr): Check for invalid name lengths.
Diffstat (limited to 'bfd')
-rw-r--r--bfd/ChangeLog6
-rw-r--r--bfd/coff-rs6000.c4
2 files changed, 10 insertions, 0 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 4bdee1c..cd904da 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2021-04-30 Nick Clifton <nickc@redhat.com>
+
+ PR 27795
+ * coff-rs6000.c (_bfd_xcoff_read_ar_hdr): Check for invalid name
+ lengths.
+
2021-04-29 Nick Clifton <nickc@redhat.com>
PR 27793
diff --git a/bfd/coff-rs6000.c b/bfd/coff-rs6000.c
index 491efba..0745421 100644
--- a/bfd/coff-rs6000.c
+++ b/bfd/coff-rs6000.c
@@ -1619,6 +1619,8 @@ _bfd_xcoff_read_ar_hdr (bfd *abfd)
return NULL;
GET_VALUE_IN_FIELD (namlen, hdr.namlen, 10);
+ if (namlen > bfd_get_file_size (abfd))
+ return NULL;
amt = sizeof (struct areltdata) + SIZEOF_AR_HDR + namlen + 1;
ret = (struct areltdata *) bfd_malloc (amt);
if (ret == NULL)
@@ -1646,6 +1648,8 @@ _bfd_xcoff_read_ar_hdr (bfd *abfd)
return NULL;
GET_VALUE_IN_FIELD (namlen, hdr.namlen, 10);
+ if (namlen > bfd_get_file_size (abfd))
+ return NULL;
amt = sizeof (struct areltdata) + SIZEOF_AR_HDR_BIG + namlen + 1;
ret = (struct areltdata *) bfd_malloc (amt);
if (ret == NULL)