diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2021-01-17 20:01:16 -0800 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2021-01-17 20:01:30 -0800 |
| commit | 994b25132814f4c2be93ce53a616a74139c4cf3c (patch) | |
| tree | 1b04e54141f4a3bc8179260b36ebf4bd480521cb /bfd | |
| parent | 25294ff049728a081c703b68f848d2cc04eef483 (diff) | |
| download | gdb-994b25132814f4c2be93ce53a616a74139c4cf3c.zip gdb-994b25132814f4c2be93ce53a616a74139c4cf3c.tar.gz gdb-994b25132814f4c2be93ce53a616a74139c4cf3c.tar.bz2 | |
ld/elf: Ignore section symbols when matching linkonce with comdat
When deciding if a single member comdat group section in file FOO should
be discarded by a linkonce section in file BAR, we check if 2 sections
define the same set of local and global symbols. When only one of the
files doesn't contain the unused section symbols in the symbol table,
such as object files generated by clang or GNU assembler with
commit d1bcae833b32f1408485ce69f844dcd7ded093a8
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Thu Jan 7 06:42:00 2021 -0800
ELF: Don't generate unused section symbols
the check will fail since one file has the extra unused section symbols.
We should ignore both undefined and section symbols in the symbol table
when making such a decision.
bfd/
PR ld/27193
* elflink.c (elf_create_symbuf): Also ignore section symbols.
ld/
PR ld/27193
* testsuite/ld-i386/i386.exp: Run PR ld/27193 test.
* testsuite/ld-i386/pr27193.dd: New file.
* testsuite/ld-i386/pr27193a.o.bz2: Likewise.
* testsuite/ld-i386/pr27193b.s: Likewise.
Diffstat (limited to 'bfd')
| -rw-r--r-- | bfd/ChangeLog | 5 | ||||
| -rw-r--r-- | bfd/elflink.c | 6 |
2 files changed, 10 insertions, 1 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index dbb240a..b947c51 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2021-01-17 H.J. Lu <hongjiu.lu@intel.com> + + PR ld/27193 + * elflink.c (elf_create_symbuf): Also ignore section symbols. + 2021-01-16 H.J. Lu <hongjiu.lu@intel.com> PR ld/23169 diff --git a/bfd/elflink.c b/bfd/elflink.c index 8794864..59a6080 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -8126,8 +8126,12 @@ elf_create_symbuf (size_t symcount, Elf_Internal_Sym *isymbuf) if (indbuf == NULL) return NULL; + /* NB: When checking if 2 sections define the same set of local and + global symbols, ignore both undefined and section symbols in the + symbol table. */ for (ind = indbuf, i = 0; i < symcount; i++) - if (isymbuf[i].st_shndx != SHN_UNDEF) + if (isymbuf[i].st_shndx != SHN_UNDEF + && ELF_ST_TYPE (isymbuf[i].st_info) != STT_SECTION) *ind++ = &isymbuf[i]; indbufend = ind; |