aboutsummaryrefslogtreecommitdiff
path: root/bfd
diff options
context:
space:
mode:
authorMike Frysinger <vapier@gentoo.org>2010-11-15 08:34:00 +0000
committerMike Frysinger <vapier@gentoo.org>2010-11-15 08:34:00 +0000
commit6936240e66f9641073c9a399bb1c0e20bbde7f97 (patch)
treecd91d31e3765a886b2021f9552644f89580a4068 /bfd
parent7eb3536ef8f7e80de61570e614c7580b84e1b96b (diff)
downloadgdb-6936240e66f9641073c9a399bb1c0e20bbde7f97.zip
gdb-6936240e66f9641073c9a399bb1c0e20bbde7f97.tar.gz
gdb-6936240e66f9641073c9a399bb1c0e20bbde7f97.tar.bz2
bfd: bfin: drop needless symbol flag handling imported from FRV
The Blackfin bfd merged some FRV code recently, and then removed pieces that didn't make sense. In the FRV code, it outputs a "_gp" symbol in its BFD whereas in the Blackfin code, we don't. So while on the FRV side it fiddles with the "flags" variable (sometimes using it for section flags and sometimes using it for symbol flags), we don't need any of that. This lead to BZ 12177 where the Blackfin code is a bit confusing. So to fix things up, remove more stuff we don't need. Shouldn't change the behavior at all. Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Diffstat (limited to 'bfd')
-rw-r--r--bfd/ChangeLog5
-rw-r--r--bfd/elf32-bfin.c6
2 files changed, 5 insertions, 6 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 35aae25..596c577 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2010-11-15 Mike Frysinger <vapier@gentoo.org>
+
+ PR binutils/12177
+ * elf32-bfin.c (_bfin_create_got_section): Drop unused flags code.
+
2010-11-12 H.J. Lu <hongjiu.lu@intel.com>
* archive.c (_bfd_get_elt_at_filepos): Copy BFD_COMPRESS and
diff --git a/bfd/elf32-bfin.c b/bfd/elf32-bfin.c
index 237391b..38f31e4 100644
--- a/bfd/elf32-bfin.c
+++ b/bfd/elf32-bfin.c
@@ -3442,14 +3442,8 @@ _bfin_create_got_section (bfd *abfd, struct bfd_link_info *info)
return FALSE;
bfinfdpic_gotfixup_section (info) = s;
- flags = BSF_GLOBAL;
- }
- else
- {
- flags = BSF_GLOBAL | BSF_WEAK;
}
- flags = pltflags;
pltflags |= SEC_CODE;
if (bed->plt_not_loaded)
pltflags &= ~ (SEC_CODE | SEC_LOAD | SEC_HAS_CONTENTS);