diff options
| author | Alan Modra <amodra@gmail.com> | 2000-06-20 12:33:21 +0000 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2000-06-20 12:33:21 +0000 |
| commit | 2ab47eed68c82a9a6d055ba3f49ca6a8a1dd2575 (patch) | |
| tree | f16dbfc601991f71c0177a7027479b3d3e3f9247 /bfd | |
| parent | b305ef96a167be657a95d273db6945fe7597e937 (diff) | |
| download | gdb-2ab47eed68c82a9a6d055ba3f49ca6a8a1dd2575.zip gdb-2ab47eed68c82a9a6d055ba3f49ca6a8a1dd2575.tar.gz gdb-2ab47eed68c82a9a6d055ba3f49ca6a8a1dd2575.tar.bz2 | |
Correct pointer comparisons relying on NULL less than any other pointer.
Alexander Aganichev's fix for ieee.c
Diffstat (limited to 'bfd')
| -rw-r--r-- | bfd/ChangeLog | 7 | ||||
| -rw-r--r-- | bfd/archive.c | 6 |
2 files changed, 10 insertions, 3 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 2e2b187..30512d1 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,10 @@ +2000-06-20 Alan Modra <alan@linuxcare.com.au> + + * archive.c (normalize): Correct pointer comparison when checking + for backslashes. + (bfd_bsd_truncate_arname): Likewise. + (bfd_gnu_truncate_arname): Likewise. + 2000-06-20 Ulf Carlsson <ulfc@engr.sgi.com> * elf-bfd.h (struct elf_obj_tdata): Define per BFD Irix 5 virtual diff --git a/bfd/archive.c b/bfd/archive.c index 5709f26..6fe5997 100644 --- a/bfd/archive.c +++ b/bfd/archive.c @@ -1188,7 +1188,7 @@ normalize (abfd, file) { /* We could have foo/bar\\baz, or foo\\bar, or d:bar. */ char *bslash = strrchr (file, '\\'); - if (bslash > filename) + if (filename == NULL || (bslash != NULL && bslash > filename)) filename = bslash; if (filename == NULL && file[0] != '\0' && file[1] == ':') filename = file + 1; @@ -1581,7 +1581,7 @@ bfd_bsd_truncate_arname (abfd, pathname, arhdr) { /* We could have foo/bar\\baz, or foo\\bar, or d:bar. */ char *bslash = strrchr (pathname, '\\'); - if (bslash > filename) + if (filename == NULL || (bslash != NULL && bslash > filename)) filename = bslash; if (filename == NULL && pathname[0] != '\0' && pathname[1] == ':') filename = pathname + 1; @@ -1632,7 +1632,7 @@ bfd_gnu_truncate_arname (abfd, pathname, arhdr) { /* We could have foo/bar\\baz, or foo\\bar, or d:bar. */ char *bslash = strrchr (pathname, '\\'); - if (bslash > filename) + if (filename == NULL || (bslash != NULL && bslash > filename)) filename = bslash; if (filename == NULL && pathname[0] != '\0' && pathname[1] == ':') filename = pathname + 1; |