diff options
| author | Alan Modra <amodra@gmail.com> | 2019-09-02 16:13:05 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2019-09-05 11:33:34 +0930 |
| commit | 89bdc77eabf5ede68322f6e47e003c1dc45b9ccb (patch) | |
| tree | 87e650254fe116fdf69906ca003a0d8c34c491ac /bfd/plugin.c | |
| parent | 809f9153986595498fbb59e547ea4e75a94a50f6 (diff) | |
| download | gdb-89bdc77eabf5ede68322f6e47e003c1dc45b9ccb.zip gdb-89bdc77eabf5ede68322f6e47e003c1dc45b9ccb.tar.gz gdb-89bdc77eabf5ede68322f6e47e003c1dc45b9ccb.tar.bz2 | |
PR24955, libbfd terminating program on out of memory
This patch fixes the worst of the cases where libbfd might terminate
a program due to calling xstrdup or xmalloc. I've also fixed some
error paths that didn't clean up properly.
PR 24955
* libbfd-in.h (bfd_strdup): New inline function.
* archive.c (_bfd_get_elt_at_filepos): Use bfd_strdup. Close
bfd on error.
* elfcode.h (_bfd_elf_bfd_from_remote_memory): Use bfd_strdup.
* opncls.c (bfd_fopen): Use bfd_strdup. Close fd and stream
on error.
(bfd_openstreamr): Use bfd_strdup.
(bfd_openr_iovec, bfd_openw, bfd_create): Likewise.
* plugin.c (try_load_plugin): Use bfd_malloc.
* libbfd.h: Regenerate.
Diffstat (limited to 'bfd/plugin.c')
| -rw-r--r-- | bfd/plugin.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/bfd/plugin.c b/bfd/plugin.c index 376e92c..5f760e9 100644 --- a/bfd/plugin.c +++ b/bfd/plugin.c @@ -262,7 +262,9 @@ try_load_plugin (const char *pname, bfd *abfd, int *has_plugin_p) } } - plugin_list_iter = (struct plugin_list_entry *) xmalloc (sizeof *plugin_list_iter); + plugin_list_iter = bfd_malloc (sizeof *plugin_list_iter); + if (plugin_list_iter == NULL) + return 0; plugin_list_iter->handle = plugin_handle; plugin_list_iter->claim_file = NULL; plugin_list_iter->next = plugin_list; |