diff options
| author | Alan Modra <amodra@gmail.com> | 2024-03-28 19:25:42 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2024-04-02 10:32:04 +1030 |
| commit | af969b14aedcc0ae27dcefab4327ff2d153dec8b (patch) | |
| tree | 0798575242610edd85068427a07f486ee5750660 /bfd/elfnn-kvx.c | |
| parent | f37f8c46c2e876a524301d6916a04cf7debb6483 (diff) | |
| download | gdb-af969b14aedcc0ae27dcefab4327ff2d153dec8b.zip gdb-af969b14aedcc0ae27dcefab4327ff2d153dec8b.tar.gz gdb-af969b14aedcc0ae27dcefab4327ff2d153dec8b.tar.bz2 | |
PR 30569, always call elf_backend_size_dynamic_sections
This largely mechanical patch is preparation for a followup patch.
For quite some time I've thought that it would be useful to call
elf_backend_size_dynamic_sections even when no dynamic objects are
seen by the linker. That's what this patch does, with some renaming.
There are no functional changes to the linker, just a move of the
dynobj test in bfd_elf_size_dynamic_sections to target backend
functions, replacing the asserts/aborts already there. No doubt some
of the current always_size_sections functions could be moved to
size_dynamic_sections but I haven't made that change.
Because both hooks are now always called, I have renamed
always_size_sections to early_size_sections and size_dynamic_sections
to late_size_sections. I condisdered calling late_size_sections plain
size_sections, since this is the usual target dynamic section sizing
hook, but decided that searching the sources for "size_sections" would
then hit early_size_sections and other functions.
Diffstat (limited to 'bfd/elfnn-kvx.c')
| -rw-r--r-- | bfd/elfnn-kvx.c | 19 |
1 files changed, 9 insertions, 10 deletions
diff --git a/bfd/elfnn-kvx.c b/bfd/elfnn-kvx.c index 8591dea..516ce2f 100644 --- a/bfd/elfnn-kvx.c +++ b/bfd/elfnn-kvx.c @@ -4031,8 +4031,8 @@ kvx_readonly_dynrelocs (struct elf_link_hash_entry * h, void * inf) /* This is the most important function of all . Innocuosly named though ! */ static bool -elfNN_kvx_size_dynamic_sections (bfd *output_bfd ATTRIBUTE_UNUSED, - struct bfd_link_info *info) +elfNN_kvx_late_size_sections (bfd *output_bfd ATTRIBUTE_UNUSED, + struct bfd_link_info *info) { struct elf_kvx_link_hash_table *htab; bfd *dynobj; @@ -4042,8 +4042,8 @@ elfNN_kvx_size_dynamic_sections (bfd *output_bfd ATTRIBUTE_UNUSED, htab = elf_kvx_hash_table ((info)); dynobj = htab->root.dynobj; - - BFD_ASSERT (dynobj != NULL); + if (dynobj == NULL) + return true; if (htab->root.dynamic_sections_created) { @@ -4357,8 +4357,7 @@ elfNN_kvx_create_small_pltn_entry (struct elf_link_hash_entry *h, _TLS_MODULE_BASE_, if needed. */ static bool -elfNN_kvx_always_size_sections (bfd *output_bfd, - struct bfd_link_info *info) +elfNN_kvx_early_size_sections (bfd *output_bfd, struct bfd_link_info *info) { asection *tls_sec; @@ -4713,8 +4712,8 @@ elfNN_kvx_plt_sym_val (bfd_vma i, const asection *plt, #define elf_backend_adjust_dynamic_symbol \ elfNN_kvx_adjust_dynamic_symbol -#define elf_backend_always_size_sections \ - elfNN_kvx_always_size_sections +#define elf_backend_early_size_sections \ + elfNN_kvx_early_size_sections #define elf_backend_check_relocs \ elfNN_kvx_check_relocs @@ -4757,8 +4756,8 @@ elfNN_kvx_plt_sym_val (bfd_vma i, const asection *plt, #define elf_backend_reloc_type_class \ elfNN_kvx_reloc_type_class -#define elf_backend_size_dynamic_sections \ - elfNN_kvx_size_dynamic_sections +#define elf_backend_late_size_sections \ + elfNN_kvx_late_size_sections #define elf_backend_can_refcount 1 #define elf_backend_can_gc_sections 1 |