diff options
author | H.J. Lu <hjl.tools@gmail.com> | 2018-05-28 08:15:06 -0700 |
---|---|---|
committer | H.J. Lu <hjl.tools@gmail.com> | 2018-05-28 08:15:21 -0700 |
commit | ac98f9e2275ffcca560eaa0bddd282a1ff94fc28 (patch) | |
tree | 93151266d6d6817f64ef156a6dc3c523a206d4d2 /bfd/elflink.c | |
parent | 03fce1c78c01a9b0e30e91be60e7af717a10bb2c (diff) | |
download | gdb-ac98f9e2275ffcca560eaa0bddd282a1ff94fc28.zip gdb-ac98f9e2275ffcca560eaa0bddd282a1ff94fc28.tar.gz gdb-ac98f9e2275ffcca560eaa0bddd282a1ff94fc28.tar.bz2 |
ld: Unify STT_GNU_IFUNC handling
Take STT_GNU_IFUNC handling scattered across targets and gather it in
the generic ELF linker.
bfd/
PR ld/23238
* elf-s390-common.c (elf_s390_add_symbol_hook): Removed.
* elf32-arc.c (elf_arc_add_symbol_hook): Likewise.
(elf_backend_add_symbol_hook): Likewise.
* elf32-m68k.c (elf_m68k_add_symbol_hook): Likewise.
(elf_backend_add_symbol_hook): Likewise.
* elf32-s390.c (elf_backend_add_symbol_hook): Likewise.
* elf32-sparc.c (elf32_sparc_add_symbol_hook): Likewise.
(elf_backend_add_symbol_hook): Likewise.
* elf64-s390.c (elf_backend_add_symbol_hook): Likewise.
* elfxx-aarch64.c (_bfd_aarch64_elf_add_symbol_hook): Likewise.
* elfxx-aarch64.h (_bfd_aarch64_elf_add_symbol_hook): Likewise.
(elf_backend_add_symbol_hook): Likewise.
* elf32-arm.c (elf32_arm_add_symbol_hook): Remove STT_GNU_IFUNC
handling.
* elf32-ppc.c (ppc_elf_add_symbol_hook): Likewise.
* elf64-ppc.c (ppc64_elf_add_symbol_hook): Likewise.
* elf64-sparc.c (elf64_sparc_add_symbol_hook): Likewise.
* elflink.c (elf_link_add_object_symbols): Set
elf_gnu_symbol_ifunc for STT_GNU_IFUNC symbols.
ld/
PR ld/23238
* testsuite/ld-ifunc/ifunc-26.d: New file.
* testsuite/ld-ifunc/ifunc-26.s: Likewise.
* testsuite/ld-ifunc/ifunc.exp: Run *.d tests without a
working compiler.
Diffstat (limited to 'bfd/elflink.c')
-rw-r--r-- | bfd/elflink.c | 15 |
1 files changed, 11 insertions, 4 deletions
diff --git a/bfd/elflink.c b/bfd/elflink.c index 05664b4..9dfd3e9 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -4680,10 +4680,17 @@ error_free_dyn: (struct bfd_link_hash_entry **) sym_hash))) goto error_free_vers; - if ((flags & BSF_GNU_UNIQUE) - && (abfd->flags & DYNAMIC) == 0 - && bfd_get_flavour (info->output_bfd) == bfd_target_elf_flavour) - elf_tdata (info->output_bfd)->has_gnu_symbols |= elf_gnu_symbol_unique; + if ((abfd->flags & DYNAMIC) == 0 + && (bfd_get_flavour (info->output_bfd) + == bfd_target_elf_flavour)) + { + if (ELF_ST_TYPE (isym->st_info) == STT_GNU_IFUNC) + elf_tdata (info->output_bfd)->has_gnu_symbols + |= elf_gnu_symbol_ifunc; + if ((flags & BSF_GNU_UNIQUE)) + elf_tdata (info->output_bfd)->has_gnu_symbols + |= elf_gnu_symbol_unique; + } h = *sym_hash; /* We need to make sure that indirect symbol dynamic flags are |