diff options
| author | Alan Modra <amodra@gmail.com> | 2023-06-07 14:16:06 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2023-06-07 14:16:06 +0930 |
| commit | ba75d1c55cb42114e3bb5c8abe37e5c2bd657a02 (patch) | |
| tree | 7e5342433baeaf8305f7a9b08ab58cfc521b4dd4 /bfd/ecoff.c | |
| parent | 0a22a8f27df7d092620dfa1f0135a2dd7b44528a (diff) | |
| download | gdb-ba75d1c55cb42114e3bb5c8abe37e5c2bd657a02.zip gdb-ba75d1c55cb42114e3bb5c8abe37e5c2bd657a02.tar.gz gdb-ba75d1c55cb42114e3bb5c8abe37e5c2bd657a02.tar.bz2 | |
_bfd_free_cached_info
doc/bfdint.texi and comments in the aout and som code about this
function are just wrong, and its name is not very apt. Better would
be _bfd_mostly_destroy, and we certainly should not be saying anything
about the possibility of later recreating anything lost by this
function. What's more, if _bfd_free_cached_info is called when
creating an archive map to reduce memory usage by throwing away
symbols, the target _close_and_cleanup function won't have access to
tdata or section bfd_user_data to tidy memory. This means most of the
target _close_and_cleanup function won't do anything, and therefore
sometimes will result in memory leaks.
This patch fixes the documentation problems and moves most of the
target _close_and_cleanup code to target _bfd_free_cached_info.
Another notable change is that bfd_generic_bfd_free_cached_info is now
defined as _bfd_free_cached_info rather than _bfd_bool_bfd_true,
ie. the default now frees objalloc memory.
Diffstat (limited to 'bfd/ecoff.c')
| -rw-r--r-- | bfd/ecoff.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/bfd/ecoff.c b/bfd/ecoff.c index 573f52d..f2626c5 100644 --- a/bfd/ecoff.c +++ b/bfd/ecoff.c @@ -110,18 +110,20 @@ _bfd_ecoff_mkobject_hook (bfd *abfd, void * filehdr, void * aouthdr) } bool -_bfd_ecoff_close_and_cleanup (bfd *abfd) +_bfd_ecoff_bfd_free_cached_info (bfd *abfd) { - struct ecoff_tdata *tdata = ecoff_data (abfd); + struct ecoff_tdata *tdata; - if (tdata != NULL && bfd_get_format (abfd) == bfd_object) + if ((bfd_get_format (abfd) == bfd_object + || bfd_get_format (abfd) == bfd_core) + && (tdata = ecoff_data (abfd)) != NULL) while (tdata->mips_refhi_list != NULL) { struct mips_hi *ref = tdata->mips_refhi_list; tdata->mips_refhi_list = ref->next; free (ref); } - return _bfd_generic_close_and_cleanup (abfd); + return _bfd_generic_bfd_free_cached_info (abfd); } /* Initialize a new section. */ |