diff options
| author | Alan Modra <amodra@gmail.com> | 2020-12-17 23:21:11 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2020-12-18 10:34:16 +1030 |
| commit | 7fbd5f4e2c143bbe28715608ca00e2e93a7d7fd4 (patch) | |
| tree | f6bc1211e0cdaecc93850eae7a46b305632c0035 /bfd/coff-mcore.c | |
| parent | bd38246a45dc199ce32b50878670bbbdf7e27ad5 (diff) | |
| download | gdb-7fbd5f4e2c143bbe28715608ca00e2e93a7d7fd4.zip gdb-7fbd5f4e2c143bbe28715608ca00e2e93a7d7fd4.tar.gz gdb-7fbd5f4e2c143bbe28715608ca00e2e93a7d7fd4.tar.bz2 | |
Remove some static buffers
Fixes possible overflow of a static buffer for powerpc with translated
messages, and on v850 when symbol names are large.
* archive.c (_bfd_ar_spacepad, _bfd_ar_sizepad): Use auto buf.
* coff-mcore.c (coff_mcore_relocate_section): Likewise.
* elf32-ppc.c (ppc_elf_unhandled_reloc): Use asprintf in place
of fixed size and possibly too small buf for translated message.
* elf64-ppc.c (ppc64_elf_unhandled_reloc): Likewise.
* elf32-v850.c (v850_elf_check_relocs): Likewise.
* ecoff.c (ecoff_type_to_string): Pass in return string buff rather
than using static buffer2. Delete dead code. Remove unnecessary
parentheses.
(_bfd_ecoff_print_symbol): Pass auto buff to ecoff_type_to_string.
* elf32-rx.c (describe_flags): Pass in return string buf rather
than using static buf.
(rx_elf_merge_private_bfd_data): Pass buf to describe_flags.
(rx_elf_print_private_bfd_data): Likewise.
* mach-o.c (cpusubtype): Pass in return string buffer rather than
using static buffer.
(bfd_mach_o_bfd_print_private_bfd_data): Pass buff to cpusubtype.
* opncls.c (separate_debug_file_exists): Make buffer an auto var.
(bfd_fill_in_gnu_debuglink_section): Likewise.
* peXXigen.c (rsrc_resource_name): Pass in return string buffer
rather than using static buffer.
(rsrc_sort_entries): Pass buff to rsrc_resource_name.
* vms-alpha.c (_bfd_vms_write_emh): Pass tbuf to get_vms_time_string.
* vms-misc.c (get_vms_time_string): Pass in return string tbuf
rather than using static tbuf.
* vms.h (get_vms_time_string): Update prototype.
Diffstat (limited to 'bfd/coff-mcore.c')
| -rw-r--r-- | bfd/coff-mcore.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/bfd/coff-mcore.c b/bfd/coff-mcore.c index fedcb0a..e5005dc 100644 --- a/bfd/coff-mcore.c +++ b/bfd/coff-mcore.c @@ -392,6 +392,7 @@ coff_mcore_relocate_section (bfd * output_bfd, reloc_howto_type * howto = NULL; struct coff_link_hash_entry * h; const char * my_name; + char buf[SYMNMLEN + 1]; symndx = rel->r_symndx; loc = contents + rel->r_vaddr - input_section->vma; @@ -436,8 +437,6 @@ coff_mcore_relocate_section (bfd * output_bfd, my_name = obj_coff_strings (input_bfd) + sym->_n._n_n._n_offset; else { - static char buf [SYMNMLEN + 1]; - strncpy (buf, sym->_n._n_name, SYMNMLEN); buf[SYMNMLEN] = '\0'; my_name = buf; |