diff options
| author | Alan Modra <amodra@gmail.com> | 2024-04-17 08:06:05 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2024-04-17 09:25:15 +0930 |
| commit | f6a18d1f55da5820fa1462950704d209a4c41817 (patch) | |
| tree | e703f76f7d220f14551a72ed7090f8534a974e3d | |
| parent | 59497587af9e1c5f029ab0bb106103dab30a5f5d (diff) | |
| download | gdb-f6a18d1f55da5820fa1462950704d209a4c41817.zip gdb-f6a18d1f55da5820fa1462950704d209a4c41817.tar.gz gdb-f6a18d1f55da5820fa1462950704d209a4c41817.tar.bz2 | |
ARC e_flags vs. objcopy
While the patch that Nick reverted in commit 3f6a060c7543 was in the
source, "FAIL: objcopy executable (pr25662)" was seen on ARC. The
failure was triggered by the .ARC.attributes section being removed by
the linker script. When a file lacking this section is copied by
objcopy, e_flags from the input is copied to the output (in this case
the value 0x406), but arc_elf_final_write_processing then logical-ors
in 0x300 when Tag_ARC_ABI_osver is not found.
* elf32-arc.c (arc_elf_final_write_processing): Don't ignore
existing e_flags for objcopy.
| -rw-r--r-- | bfd/elf32-arc.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/bfd/elf32-arc.c b/bfd/elf32-arc.c index 7e94373..bd18299 100644 --- a/bfd/elf32-arc.c +++ b/bfd/elf32-arc.c @@ -1045,9 +1045,6 @@ static bool arc_elf_final_write_processing (bfd *abfd) { unsigned long emf; - int osver = bfd_elf_get_obj_attr_int (abfd, OBJ_ATTR_PROC, - Tag_ARC_ABI_osver); - flagword e_flags = elf_elfheader (abfd)->e_flags & ~EF_ARC_OSABI_MSK; switch (bfd_get_mach (abfd)) { @@ -1062,12 +1059,15 @@ arc_elf_final_write_processing (bfd *abfd) elf_elfheader (abfd)->e_machine = emf; /* Record whatever is the current syscall ABI version. */ + int osver = bfd_elf_get_obj_attr_int (abfd, OBJ_ATTR_PROC, + Tag_ARC_ABI_osver); + flagword e_flags = elf_elfheader (abfd)->e_flags; if (osver) - e_flags |= ((osver & 0x0f) << 8); - else + e_flags = (e_flags & ~EF_ARC_OSABI_MSK) | ((osver & 0x0f) << 8); + else if ((e_flags & EF_ARC_OSABI_MSK) == 0) e_flags |= E_ARC_OSABI_V3; - elf_elfheader (abfd)->e_flags |= e_flags; + elf_elfheader (abfd)->e_flags = e_flags; return _bfd_elf_final_write_processing (abfd); } |