aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Tromey <tromey@redhat.com>2013-12-19 08:21:20 -0700
committerTom Tromey <tromey@redhat.com>2014-02-19 07:48:39 -0700
commitee97f592f2d9edf4ae720a68893af5cbaedd1be9 (patch)
tree4600d1e3b5b372e45fbfc7b6ddfc2b0a798c8471
parent6dc7fcf4c1e9cbea86ebd067ce226ffdffa16c08 (diff)
downloadgdb-ee97f592f2d9edf4ae720a68893af5cbaedd1be9.zip
gdb-ee97f592f2d9edf4ae720a68893af5cbaedd1be9.tar.gz
gdb-ee97f592f2d9edf4ae720a68893af5cbaedd1be9.tar.bz2
convert to_stop_recording
2014-02-19 Tom Tromey <tromey@redhat.com> * record.c (record_stop): Unconditionally delegate. * target-delegates.c: Rebuild. * target.c (target_stop_recording): Unconditionally delegate. * target.h (struct target_ops) <to_stop_recording>: Use TARGET_DEFAULT_IGNORE.
-rw-r--r--gdb/ChangeLog8
-rw-r--r--gdb/record.c3
-rw-r--r--gdb/target-delegates.c15
-rw-r--r--gdb/target.c11
-rw-r--r--gdb/target.h3
5 files changed, 27 insertions, 13 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 644ebfd..aa699ba 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,13 @@
2014-02-19 Tom Tromey <tromey@redhat.com>
+ * record.c (record_stop): Unconditionally delegate.
+ * target-delegates.c: Rebuild.
+ * target.c (target_stop_recording): Unconditionally delegate.
+ * target.h (struct target_ops) <to_stop_recording>: Use
+ TARGET_DEFAULT_IGNORE.
+
+2014-02-19 Tom Tromey <tromey@redhat.com>
+
* target-delegates.c: Rebuild.
* target.c (target_enable_btrace): Unconditionally delegate.
* target.h (struct target_ops) <to_enable_btrace>: Use
diff --git a/gdb/record.c b/gdb/record.c
index 9dd02e8..5a7a88c 100644
--- a/gdb/record.c
+++ b/gdb/record.c
@@ -114,8 +114,7 @@ record_stop (struct target_ops *t)
{
DEBUG ("stop %s", t->to_shortname);
- if (t->to_stop_recording != NULL)
- t->to_stop_recording (t);
+ t->to_stop_recording (t);
}
/* Unpush the record target. */
diff --git a/gdb/target-delegates.c b/gdb/target-delegates.c
index df17c7b..4b90a2f 100644
--- a/gdb/target-delegates.c
+++ b/gdb/target-delegates.c
@@ -1353,6 +1353,18 @@ tdefault_read_btrace (struct target_ops *self, VEC (btrace_block_s) **arg1, stru
}
static void
+delegate_stop_recording (struct target_ops *self)
+{
+ self = self->beneath;
+ self->to_stop_recording (self);
+}
+
+static void
+tdefault_stop_recording (struct target_ops *self)
+{
+}
+
+static void
delegate_save_record (struct target_ops *self, const char *arg1)
{
self = self->beneath;
@@ -1752,6 +1764,8 @@ install_delegators (struct target_ops *ops)
ops->to_teardown_btrace = delegate_teardown_btrace;
if (ops->to_read_btrace == NULL)
ops->to_read_btrace = delegate_read_btrace;
+ if (ops->to_stop_recording == NULL)
+ ops->to_stop_recording = delegate_stop_recording;
if (ops->to_save_record == NULL)
ops->to_save_record = delegate_save_record;
if (ops->to_delete_record == NULL)
@@ -1897,6 +1911,7 @@ install_dummy_methods (struct target_ops *ops)
ops->to_disable_btrace = tdefault_disable_btrace;
ops->to_teardown_btrace = tdefault_teardown_btrace;
ops->to_read_btrace = tdefault_read_btrace;
+ ops->to_stop_recording = tdefault_stop_recording;
ops->to_save_record = tdefault_save_record;
ops->to_delete_record = tdefault_delete_record;
ops->to_record_is_replaying = tdefault_record_is_replaying;
diff --git a/gdb/target.c b/gdb/target.c
index 547afcc..ef7374e 100644
--- a/gdb/target.c
+++ b/gdb/target.c
@@ -3818,16 +3818,7 @@ target_read_btrace (VEC (btrace_block_s) **btrace,
void
target_stop_recording (void)
{
- struct target_ops *t;
-
- for (t = current_target.beneath; t != NULL; t = t->beneath)
- if (t->to_stop_recording != NULL)
- {
- t->to_stop_recording (t);
- return;
- }
-
- /* This is optional. */
+ current_target.to_stop_recording (&current_target);
}
/* See target.h. */
diff --git a/gdb/target.h b/gdb/target.h
index bbc0ecd..1437cc4 100644
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -1028,7 +1028,8 @@ struct target_ops
TARGET_DEFAULT_NORETURN (tcomplain ());
/* Stop trace recording. */
- void (*to_stop_recording) (struct target_ops *);
+ void (*to_stop_recording) (struct target_ops *)
+ TARGET_DEFAULT_IGNORE ();
/* Print information about the recording. */
void (*to_info_record) (struct target_ops *);