diff options
| author | Trevor Saunders <tbsaunde+binutils@tbsaunde.org> | 2016-04-02 08:22:05 -0400 |
|---|---|---|
| committer | Trevor Saunders <tbsaunde+binutils@tbsaunde.org> | 2016-04-03 19:13:42 -0400 |
| commit | e1ec8109ab32b653c860193798bb13a779e867f5 (patch) | |
| tree | f63b52054415bb0c08dea7e19b2c097ffcfa57bf | |
| parent | f73e41ef3703be34db1c7e08271e6ac8bd758144 (diff) | |
| download | gdb-e1ec8109ab32b653c860193798bb13a779e867f5.zip gdb-e1ec8109ab32b653c860193798bb13a779e867f5.tar.gz gdb-e1ec8109ab32b653c860193798bb13a779e867f5.tar.bz2 | |
bfin: simplify current_inputline
Its not used for anything outside of md_assemble () so it doesn't need to be
extern. While we are there we can replace free () and xmalloc () with
XRESIZEVEC which should be faster.
gas/ChangeLog:
2016-04-03 Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
* config/bfin-parse.y (current_inputline): Remove definition.
* config/tc-bfin.c (md_assemble): Simplify use of current_inputline.
| -rw-r--r-- | gas/ChangeLog | 5 | ||||
| -rw-r--r-- | gas/config/bfin-parse.y | 1 | ||||
| -rw-r--r-- | gas/config/tc-bfin.c | 6 |
3 files changed, 7 insertions, 5 deletions
diff --git a/gas/ChangeLog b/gas/ChangeLog index 8d6ba9b..d4886c0 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,5 +1,10 @@ 2016-04-03 Trevor Saunders <tbsaunde+binutils@tbsaunde.org> + * config/bfin-parse.y (current_inputline): Remove definition. + * config/tc-bfin.c (md_assemble): Simplify use of current_inputline. + +2016-04-03 Trevor Saunders <tbsaunde+binutils@tbsaunde.org> + * config/tc-avr.c (md_parse_option): Use strcasecmp () to compare strings. diff --git a/gas/config/bfin-parse.y b/gas/config/bfin-parse.y index be53280..26070c1 100644 --- a/gas/config/bfin-parse.y +++ b/gas/config/bfin-parse.y @@ -160,7 +160,6 @@ static Expr_Node *unary (Expr_Op_Type, Expr_Node *); static void notethat (const char *, ...); -char *current_inputline; extern char *yytext; int yyerror (const char *); diff --git a/gas/config/tc-bfin.c b/gas/config/tc-bfin.c index caa89c6..4f9ad7e 100644 --- a/gas/config/tc-bfin.c +++ b/gas/config/tc-bfin.c @@ -485,20 +485,18 @@ void md_assemble (char *line) { char *toP = 0; - extern char *current_inputline; int size, insn_size; struct bfin_insn *tmp_insn; size_t len; static size_t buffer_len = 0; + static char *current_inputline; parse_state state; len = strlen (line); if (len + 2 > buffer_len) { - if (buffer_len > 0) - free (current_inputline); buffer_len = len + 40; - current_inputline = xmalloc (buffer_len); + current_inputline = XRESIZEVEC (char, current_inputline, buffer_len); } memcpy (current_inputline, line, len); current_inputline[len] = ';'; |