diff options
| author | Indu Bhagat <indu.bhagat@oracle.com> | 2023-06-01 09:41:04 -0700 |
|---|---|---|
| committer | Indu Bhagat <indu.bhagat@oracle.com> | 2023-06-01 09:41:04 -0700 |
| commit | d987df5c95340a8b41b23d68ad6a8f9f33485835 (patch) | |
| tree | e09f74afc5d4154c659cb269715f0e1366e5d801 | |
| parent | a5ffdcafc76c3f77c1c05fabe1544e004e9ef358 (diff) | |
| download | gdb-d987df5c95340a8b41b23d68ad6a8f9f33485835.zip gdb-d987df5c95340a8b41b23d68ad6a8f9f33485835.tar.gz gdb-d987df5c95340a8b41b23d68ad6a8f9f33485835.tar.bz2 | |
libsframe: avoid using magic number
Define a new constant for the maximum number of stack offsets handled in
libsframe, and use it. Note that the SFrame format does not define such
a constant (limit). This is an implmentation-defined constant in
libsframe.
include/
* sframe-api.h (MAX_NUM_STACK_OFFSETS): New definition.
libsframe/
* sframe.c (sframe_fre_sanity_check_p): Use it.
| -rw-r--r-- | include/sframe-api.h | 5 | ||||
| -rw-r--r-- | libsframe/sframe.c | 2 |
2 files changed, 5 insertions, 2 deletions
diff --git a/include/sframe-api.h b/include/sframe-api.h index 405e30c..3245bc8 100644 --- a/include/sframe-api.h +++ b/include/sframe-api.h @@ -31,7 +31,10 @@ extern "C" typedef struct sframe_decoder_ctx sframe_decoder_ctx; typedef struct sframe_encoder_ctx sframe_encoder_ctx; -#define MAX_OFFSET_BYTES (SFRAME_FRE_OFFSET_4B * 2 * 3) +#define MAX_NUM_STACK_OFFSETS 3 + +#define MAX_OFFSET_BYTES \ + ((SFRAME_FRE_OFFSET_4B * 2 * MAX_NUM_STACK_OFFSETS)) /* User interfacing SFrame Row Entry. An abstraction provided by libsframe so the consumer is decoupled from diff --git a/libsframe/sframe.c b/libsframe/sframe.c index 97b4910..a97c64f 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -299,7 +299,7 @@ sframe_fre_sanity_check_p (sframe_frame_row_entry *frep) return false; offset_cnt = sframe_fre_get_offset_count (fre_info); - if (offset_cnt > 3) + if (offset_cnt > MAX_NUM_STACK_OFFSETS) return false; return true; |