diff options
| author | Alan Modra <amodra@gmail.com> | 2020-05-18 13:30:59 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2020-05-18 13:46:27 +0930 |
| commit | d402189f2faa0aaa9fb8ad4669fdf0059946cd8a (patch) | |
| tree | 9eab0921b5514839e2970951fbdcc7e11ef8546c | |
| parent | 503648e41efa19dfb059757ffddf0206b6060520 (diff) | |
| download | gdb-d402189f2faa0aaa9fb8ad4669fdf0059946cd8a.zip gdb-d402189f2faa0aaa9fb8ad4669fdf0059946cd8a.tar.gz gdb-d402189f2faa0aaa9fb8ad4669fdf0059946cd8a.tar.bz2 | |
Re: Fix tight loop on recursively-defined symbols
sy_resolving ought to not be set for a struct local_symbol, but it is
apparent from local_symbol_make that the field is not initialised.
* symbols.c (resolve_symbol_value): Invoke LOCAL_SYMBOL_CHECK
before looking at add_symbol->sy_flags.sy_resolving.
| -rw-r--r-- | gas/ChangeLog | 5 | ||||
| -rw-r--r-- | gas/symbols.c | 1 |
2 files changed, 6 insertions, 0 deletions
diff --git a/gas/ChangeLog b/gas/ChangeLog index 3b8ea16..7fb6b5d 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,8 @@ +2020-05-18 Alan Modra <amodra@gmail.com> + + * symbols.c (resolve_symbol_value): Invoke LOCAL_SYMBOL_CHECK + before looking at add_symbol->sy_flags. + 2020-05-18 Hongtao Liu <hongtao.liu@intel.com> * config/tc-i386.c: Not handle lret/iret. diff --git a/gas/symbols.c b/gas/symbols.c index 711730d..b1376a5 100644 --- a/gas/symbols.c +++ b/gas/symbols.c @@ -1389,6 +1389,7 @@ resolve_symbol_value (symbolS *symp) /* Don't leave symbol loops. */ if (finalize_syms + && !LOCAL_SYMBOL_CHECK (add_symbol) && add_symbol->sy_flags.sy_resolving) break; |