diff options
| author | Jan Beulich <jbeulich@suse.com> | 2024-07-19 11:55:54 +0200 |
|---|---|---|
| committer | Jan Beulich <jbeulich@suse.com> | 2024-07-19 11:55:54 +0200 |
| commit | cfa18744d435b55bbbbc5ef1ae1df67e84aa1777 (patch) | |
| tree | 78821f532714f70f84f1f6d66731dc39dcc4dd30 | |
| parent | fd05d6b739fd06bbd993e6a673841977d33dd763 (diff) | |
| download | gdb-cfa18744d435b55bbbbc5ef1ae1df67e84aa1777.zip gdb-cfa18744d435b55bbbbc5ef1ae1df67e84aa1777.tar.gz gdb-cfa18744d435b55bbbbc5ef1ae1df67e84aa1777.tar.bz2 | |
Arm: correct macro use in gas testsuite
The way the inner macro invocations are written doesn't quite work as
expected (and would actually break subsequently): Due to overly
aggressive removal of whitespace by the scrubber, the incoming \sym and
\offset arguments actually get concatenated; an empty 3rd argument is
being passed to ldrtest2. That just so happened to work as intended; any
use of \offset alone would have exposed the problem. Quote the 3rd
argument, thus retaining enough whitespace to be independent of scrubber
internals.
| -rw-r--r-- | gas/testsuite/gas/arm/group-reloc-ldrs-encoding-bad.s | 2 | ||||
| -rw-r--r-- | gas/testsuite/gas/arm/group-reloc-ldrs.s | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/gas/testsuite/gas/arm/group-reloc-ldrs-encoding-bad.s b/gas/testsuite/gas/arm/group-reloc-ldrs-encoding-bad.s index ac7a90f..7799bf1 100644 --- a/gas/testsuite/gas/arm/group-reloc-ldrs-encoding-bad.s +++ b/gas/testsuite/gas/arm/group-reloc-ldrs-encoding-bad.s @@ -14,7 +14,7 @@ .macro ldrtest load store sym offset - ldrtest2 \load \sym \offset + ldrtest2 \load \sym "\offset" \store r0, [r0, #:pc_g1:(\sym \offset)] \store r0, [r0, #:pc_g2:(\sym \offset)] diff --git a/gas/testsuite/gas/arm/group-reloc-ldrs.s b/gas/testsuite/gas/arm/group-reloc-ldrs.s index fa74e7e..96655e1 100644 --- a/gas/testsuite/gas/arm/group-reloc-ldrs.s +++ b/gas/testsuite/gas/arm/group-reloc-ldrs.s @@ -14,7 +14,7 @@ .macro ldrtest load store sym offset - ldrtest2 \load \sym \offset + ldrtest2 \load \sym "\offset" \store r0, [r0, #:pc_g1:(\sym \offset)] \store r0, [r0, #:pc_g2:(\sym \offset)] |