diff options
| author | Markus Metzger <markus.t.metzger@intel.com> | 2017-01-20 09:05:03 +0100 |
|---|---|---|
| committer | Markus Metzger <markus.t.metzger@intel.com> | 2017-02-01 14:34:31 +0100 |
| commit | cf77c34ea71c27c3cb6dd31c9448249276e8a8a6 (patch) | |
| tree | 322c7fa73050a9bcf38f1605fb74952998fd74c7 | |
| parent | ce7903706d30e5fa335dd96eaaab3ae914ff8e64 (diff) | |
| download | gdb-cf77c34ea71c27c3cb6dd31c9448249276e8a8a6.zip gdb-cf77c34ea71c27c3cb6dd31c9448249276e8a8a6.tar.gz gdb-cf77c34ea71c27c3cb6dd31c9448249276e8a8a6.tar.bz2 | |
thread: add can_access_registers_ptid
Add a function can_access_registers_ptid that behaves like
validate_registers_access but returns a boolean value instead of throwing an
exception.
gdb/
* gdbthread.h (can_access_registers_ptid): New.
* thread.c (can_access_registers_ptid): New.
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/gdbthread.h | 4 | ||||
| -rw-r--r-- | gdb/thread.c | 20 |
3 files changed, 29 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 710b181..5ce8912 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-02-01 Markus Metzger <markus.t.metzger@intel.com> + + * gdbthread.h (can_access_registers_ptid): New. + * thread.c (can_access_registers_ptid): New. + 2017-02-01 Pedro Alves <palves@redhat.com> * i386-tdep.c (i386_fast_tracepoint_valid_at): Use gdb_insn_length. diff --git a/gdb/gdbthread.h b/gdb/gdbthread.h index 455cfd8..06ed78f 100644 --- a/gdb/gdbthread.h +++ b/gdb/gdbthread.h @@ -625,6 +625,10 @@ extern void thread_cancel_execution_command (struct thread_info *thr); executing). */ extern void validate_registers_access (void); +/* Check whether it makes sense to access a register of PTID at this point. + Returns true if registers may be accessed; false otherwise. */ +extern bool can_access_registers_ptid (ptid_t ptid); + /* Returns whether to show which thread hit the breakpoint, received a signal, etc. and ended up causing a user-visible stop. This is true iff we ever detected multiple threads. */ diff --git a/gdb/thread.c b/gdb/thread.c index e45b257..99fe424 100644 --- a/gdb/thread.c +++ b/gdb/thread.c @@ -1141,6 +1141,26 @@ validate_registers_access (void) error (_("Selected thread is running.")); } +/* See gdbthread.h. */ + +bool +can_access_registers_ptid (ptid_t ptid) +{ + /* No thread, no registers. */ + if (ptid_equal (ptid, null_ptid)) + return false; + + /* Don't try to read from a dead thread. */ + if (is_exited (ptid)) + return false; + + /* ... or from a spinning thread. FIXME: see validate_registers_access. */ + if (is_executing (ptid)) + return false; + + return true; +} + int pc_in_thread_step_range (CORE_ADDR pc, struct thread_info *thread) { |