diff options
| author | Chen Gang <gang.chen.5i5j@gmail.com> | 2015-01-31 06:06:38 +0800 |
|---|---|---|
| committer | Chen Gang <gang.chen.5i5j@gmail.com> | 2015-02-03 04:03:38 +0800 |
| commit | cd71915c7738f0992daefe0320b10e3b1960535c (patch) | |
| tree | ce2be59d429be90d15f53f038dde8814949bae6b | |
| parent | c9ba137e2157b989b878198f94c7d5f01a937500 (diff) | |
| download | gdb-cd71915c7738f0992daefe0320b10e3b1960535c.zip gdb-cd71915c7738f0992daefe0320b10e3b1960535c.tar.gz gdb-cd71915c7738f0992daefe0320b10e3b1960535c.tar.bz2 | |
sim: Be sure of calling freeargv() after successfully call buildargv().
Or there will be memory leak.
2015-02-02 Chen Gang <gang.chen.5i5j@gmail.com>
* mcore/interp.c (sim_do_command): Call freeargv() before return.
| -rw-r--r-- | sim/ChangeLog | 4 | ||||
| -rw-r--r-- | sim/mcore/interp.c | 3 |
2 files changed, 7 insertions, 0 deletions
diff --git a/sim/ChangeLog b/sim/ChangeLog index 9ddee64..628e6a8 100644 --- a/sim/ChangeLog +++ b/sim/ChangeLog @@ -1,5 +1,9 @@ 2015-02-02 Chen Gang <gang.chen.5i5j@gmail.com> + * mcore/interp.c (sim_do_command): Call freeargv() before return. + +2015-02-02 Chen Gang <gang.chen.5i5j@gmail.com> + * common/sim-options.c (sim_args_command): Call freeargv() when failure occurs. diff --git a/sim/mcore/interp.c b/sim/mcore/interp.c index d2edd12..dfaa6aa 100644 --- a/sim/mcore/interp.c +++ b/sim/mcore/interp.c @@ -2143,6 +2143,7 @@ sim_do_command (sd, cmd) if ((simargv[1] == NULL) || (simargv[2] == NULL)) { fprintf (stderr, "Error: missing argument to watch cmd.\n"); + freeargv (simargv); return; } @@ -2187,6 +2188,8 @@ sim_do_command (sd, cmd) fprintf (stderr,"Error: \"%s\" is not a valid M.CORE simulator command.\n", cmd); } + + freeargv (simargv); } else { |