diff options
| author | Joel Brobecker <brobecker@gnat.com> | 2010-05-17 21:32:57 +0000 |
|---|---|---|
| committer | Joel Brobecker <brobecker@gnat.com> | 2010-05-17 21:32:57 +0000 |
| commit | c81c812a7aa355526da81443df27aa7ce6699800 (patch) | |
| tree | 5f727ee91432cfaa6e8baaca86992b4bcb5af6dc | |
| parent | d59b6f6c38a3e9c229dae40bd6c668be47fe8e48 (diff) | |
| download | gdb-c81c812a7aa355526da81443df27aa7ce6699800.zip gdb-c81c812a7aa355526da81443df27aa7ce6699800.tar.gz gdb-c81c812a7aa355526da81443df27aa7ce6699800.tar.bz2 | |
make parameter being watched is a non-constant.
The gdb.ada/watch_arg testcase is testing a situation where we are
leaving the scope where a parameter being watched is defined. The
testcase is a little non-sensical that we're watching a parameter
declared as an "access integer", which in non-Ada terms means
a constant pointer. Doesn't make much sense to watch a constant...
So this patch changes the code a little to use an "in out Integer",
which makes the parameter a non-constant integer, rather than a
constant access Integer. I verified that I could still reproduce
the problem with the original debugger and the modified testcase.
This was motivated by a patch that Sergio is about to submit which
will forbid the user from watching a constant (discussed on IRC)
2010-05-17 Joel Brobecker <brobecker@adacore.com>
* gdb.ada/watch_arg/watch.adb: Rewrite testcase to avoid the
parameter that we want to watch being a constant.
Tested on both sparc-solaris (where the ancient debugger could still
run ;-), and on x86_64-linux.
| -rw-r--r-- | gdb/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.ada/watch_arg/watch.adb | 8 |
2 files changed, 9 insertions, 4 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index bc55d70..91fea82 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,10 @@ 2010-05-17 Joel Brobecker <brobecker@adacore.com> + * gdb.ada/watch_arg/watch.adb: Rewrite testcase to avoid the + parameter that we want to watch being a constant. + +2010-05-17 Joel Brobecker <brobecker@adacore.com> + * gdb.ada/cond_lang: New testcase. 2010-05-17 Joel Brobecker <brobecker@adacore.com> diff --git a/gdb/testsuite/gdb.ada/watch_arg/watch.adb b/gdb/testsuite/gdb.ada/watch_arg/watch.adb index b95e3a0..3b7cb27 100644 --- a/gdb/testsuite/gdb.ada/watch_arg/watch.adb +++ b/gdb/testsuite/gdb.ada/watch_arg/watch.adb @@ -15,15 +15,15 @@ procedure Watch is - procedure Foo (X : access Integer) is + procedure Foo (X : in out Integer) is begin - X.all := 3; -- BREAK1 + X := 3; -- BREAK1 end Foo; - X : aliased Integer := 1; + X : Integer := 1; begin - Foo (X'Access); + Foo (X); X := 2; -- BREAK2 end Watch; |