aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Clifton <nickc@redhat.com>2020-01-09 14:32:49 +0000
committerNick Clifton <nickc@redhat.com>2020-01-09 14:32:49 +0000
commitbce58db4fb1112529a54387c7fdaa1042859f5fb (patch)
tree052146d8b209a55878fae2cbdba1c831deeb0f97
parentabb78b78c4184d2ac968362229adae268385a21c (diff)
downloadgdb-bce58db4fb1112529a54387c7fdaa1042859f5fb.zip
gdb-bce58db4fb1112529a54387c7fdaa1042859f5fb.tar.gz
gdb-bce58db4fb1112529a54387c7fdaa1042859f5fb.tar.bz2
Fix the cast used to prevent compile time warning about an always false test.
PR 25224 * z80-dis.c (ld_ii_ii): Use correct cast.
-rw-r--r--opcodes/ChangeLog5
-rw-r--r--opcodes/z80-dis.c2
2 files changed, 6 insertions, 1 deletions
diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 396549b..eb67b55 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,8 @@
+2020-01-09 Nick Clifton <nickc@redhat.com>
+
+ PR 25224
+ * z80-dis.c (ld_ii_ii): Use correct cast.
+
2020-01-03 Sergey Belyashov <sergey.belyashov@gmail.com>
PR 25224
diff --git a/opcodes/z80-dis.c b/opcodes/z80-dis.c
index 8dc7598..b6f0606 100644
--- a/opcodes/z80-dis.c
+++ b/opcodes/z80-dis.c
@@ -603,7 +603,7 @@ ld_ii_ii (struct buffer *buf, disassemble_info * info, const char *txt)
int p;
static const char *ii[2] = { "ix", "iy" };
- p = (buf->data[buf->n_fetch - 2] == (char) 0xdd) ? 0 : 1;
+ p = (buf->data[buf->n_fetch - 2] == (signed char) 0xdd) ? 0 : 1;
c = buf->data[buf->n_fetch - 1];
if ((c & 0x07) != 0x07)
p = 1 - p; /* 0 -> 1, 1 -> 0 */