diff options
| author | Tom de Vries <tdevries@suse.de> | 2020-03-11 08:37:04 +0100 |
|---|---|---|
| committer | Tom de Vries <tdevries@suse.de> | 2020-03-11 08:37:04 +0100 |
| commit | b76f3a42371cb0d83a1128a434852447da76b5e9 (patch) | |
| tree | db14db6303eadc4fb0a1b100ef3afdb68e31fe40 | |
| parent | 119789424b62321e74a18fc1c088ebf479d999c4 (diff) | |
| download | gdb-b76f3a42371cb0d83a1128a434852447da76b5e9.zip gdb-b76f3a42371cb0d83a1128a434852447da76b5e9.tar.gz gdb-b76f3a42371cb0d83a1128a434852447da76b5e9.tar.bz2 | |
[gdb/testsuite] Set EDITOR to true before using edit
The test-case gdb.base/list-ambiguous.exp normally passes, but with target
board readnow, some tests fail.
In particular, for this test, edit doesn't fail as expected:
...
# While at it, test the "edit" command as well, since it shares
# code with "list".
gdb_test "edit $symbol" \
"Specified line is ambiguous:\r\n${h0_re}\r\n${h1_re}"
...
and the editor is launched, in my case:
...
$ echo $EDITOR
/home/vries/bin/emacs-nw.sh
...
which result in all subsequent tests failing with timeout, and an editor
backup file in my sources:
...
$ git status --ignored
On branch master
Ignored files:
(use "git add -f <file>..." to include in what will be committed)
gdb/testsuite/gdb.base/#list-ambiguous0.c#
nothing to commit, working tree clean
...
Fix this by setting EDITOR to true before starting gdb in this test-case.
Tested on x86_64-linux.
gdb/testsuite/ChangeLog:
2020-03-11 Tom de Vries <tdevries@suse.de>
* gdb.base/list-ambiguous.exp: Set EDITOR to true.
| -rw-r--r-- | gdb/testsuite/ChangeLog | 4 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.base/list-ambiguous.exp | 4 |
2 files changed, 8 insertions, 0 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index c5aa0e6..46442c5 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,9 @@ 2020-03-11 Tom de Vries <tdevries@suse.de> + * gdb.base/list-ambiguous.exp: Set EDITOR to true. + +2020-03-11 Tom de Vries <tdevries@suse.de> + * gdb.ada/access_to_packed_array.exp: Test printing of expanded symtabs. diff --git a/gdb/testsuite/gdb.base/list-ambiguous.exp b/gdb/testsuite/gdb.base/list-ambiguous.exp index 8d63938..13c15d2 100644 --- a/gdb/testsuite/gdb.base/list-ambiguous.exp +++ b/gdb/testsuite/gdb.base/list-ambiguous.exp @@ -18,6 +18,10 @@ standard_testfile list-ambiguous0.c list-ambiguous1.c +# Set EDITOR to true to prevent that GDB's edit command starts an actual +# editor. +setenv EDITOR true + if {[prepare_for_testing "failed to prepare" $testfile [list $srcfile $srcfile2] \ {debug}]} { return -1 |